From e66ce2f4181b14ffe323e559805b2a5f97b0c1bd Mon Sep 17 00:00:00 2001 From: Fred Reitberger Date: Wed, 5 Jul 2023 15:43:19 -0400 Subject: soc/amd/*/Makefile.inc: Use _tohex instead of printf Use the _tohex function to convert values to hex instead of 'shell printf' TEST=timeless builds identical for grunt,dalboz,guybrush,chausie,birman Signed-off-by: Fred Reitberger Change-Id: Ic7f7d1b764479088cc0980b208d8d603bc712832 Reviewed-on: https://review.coreboot.org/c/coreboot/+/76314 Reviewed-by: Eric Lai Reviewed-by: Marshall Dawson Tested-by: build bot (Jenkins) Reviewed-by: Felix Held Reviewed-by: Matt DeVillier --- src/soc/amd/mendocino/Makefile.inc | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) (limited to 'src/soc/amd/mendocino') diff --git a/src/soc/amd/mendocino/Makefile.inc b/src/soc/amd/mendocino/Makefile.inc index 466123461c..d3d5601e13 100644 --- a/src/soc/amd/mendocino/Makefile.inc +++ b/src/soc/amd/mendocino/Makefile.inc @@ -262,7 +262,7 @@ $(obj)/amdfw.rom: $(call strip_quotes, $(PSP_BIOSBIN_FILE)) \ $(OPT_VERSTAGE_SIG_FILE) \ $(OPT_SPL_TABLE_FILE) \ $(OPT_MANIFEST) \ - --location $(shell printf "%#x" $(MENDOCINO_FWM_POSITION)) \ + --location $(call _tohex,$(MENDOCINO_FWM_POSITION)) \ --output $@ ifeq ($(CONFIG_CBFS_VERIFICATION)$(CONFIG_VBOOT_STARTS_IN_BOOTBLOCK),yy) @@ -288,8 +288,8 @@ $(obj)/amdfw_a.rom: $(obj)/amdfw.rom $(OPT_SIGNED_AMDFW_A_POSITION) \ $(OPT_SIGNED_AMDFW_A_FILE) \ $(OPT_PSP_LOAD_MP2_FW) \ - --location $(shell printf "%#x" $(MENDOCINO_FW_A_POSITION)) \ - --body-location $(shell printf "%#x" $$(($(MENDOCINO_FW_A_POSITION) + $(MENDOCINO_FW_BODY_OFFSET)))) \ + --location $(call _tohex,$(MENDOCINO_FW_A_POSITION)) \ + --body-location $(call _tohex,$$(($(MENDOCINO_FW_A_POSITION) + $(MENDOCINO_FW_BODY_OFFSET)))) \ --anywhere \ --output $@ @@ -304,8 +304,8 @@ $(obj)/amdfw_b.rom: $(obj)/amdfw.rom $(OPT_SIGNED_AMDFW_B_POSITION) \ $(OPT_SIGNED_AMDFW_B_FILE) \ $(OPT_PSP_LOAD_MP2_FW) \ - --location $(shell printf "%#x" $(MENDOCINO_FW_B_POSITION)) \ - --body-location $(shell printf "%#x" $$(($(MENDOCINO_FW_B_POSITION) + $(MENDOCINO_FW_BODY_OFFSET)))) \ + --location $(call _tohex,$(MENDOCINO_FW_B_POSITION)) \ + --body-location $(call _tohex,$$(($(MENDOCINO_FW_B_POSITION) + $(MENDOCINO_FW_BODY_OFFSET)))) \ --anywhere \ --output $@ -- cgit v1.2.3