From e66ce2f4181b14ffe323e559805b2a5f97b0c1bd Mon Sep 17 00:00:00 2001 From: Fred Reitberger Date: Wed, 5 Jul 2023 15:43:19 -0400 Subject: soc/amd/*/Makefile.inc: Use _tohex instead of printf Use the _tohex function to convert values to hex instead of 'shell printf' TEST=timeless builds identical for grunt,dalboz,guybrush,chausie,birman Signed-off-by: Fred Reitberger Change-Id: Ic7f7d1b764479088cc0980b208d8d603bc712832 Reviewed-on: https://review.coreboot.org/c/coreboot/+/76314 Reviewed-by: Eric Lai Reviewed-by: Marshall Dawson Tested-by: build bot (Jenkins) Reviewed-by: Felix Held Reviewed-by: Matt DeVillier --- src/soc/amd/glinda/Makefile.inc | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'src/soc/amd/glinda') diff --git a/src/soc/amd/glinda/Makefile.inc b/src/soc/amd/glinda/Makefile.inc index c35c3fea13..a537378372 100644 --- a/src/soc/amd/glinda/Makefile.inc +++ b/src/soc/amd/glinda/Makefile.inc @@ -238,7 +238,7 @@ $(obj)/amdfw.rom: $(call strip_quotes, $(PSP_BIOSBIN_FILE)) \ $(OPT_VERSTAGE_FILE) \ $(OPT_VERSTAGE_SIG_FILE) \ $(OPT_SPL_TABLE_FILE) \ - --location $(shell printf "%#x" $(GLINDA_FWM_POSITION)) \ + --location $(call _tohex,$(GLINDA_FWM_POSITION)) \ --output $@ $(PSP_BIOSBIN_FILE): $(PSP_ELF_FILE) $(AMDCOMPRESS) @@ -257,7 +257,7 @@ $(obj)/amdfw_a.rom: $(obj)/amdfw.rom $(OPT_SPL_RW_AB_TABLE_FILE) \ $(OPT_SIGNED_AMDFW_A_POSITION) \ $(OPT_SIGNED_AMDFW_A_FILE) \ - --location $(shell printf "%#x" $(GLINDA_FW_A_POSITION)) \ + --location $(call _tohex,$(GLINDA_FW_A_POSITION)) \ --anywhere \ --output $@ @@ -271,7 +271,7 @@ $(obj)/amdfw_b.rom: $(obj)/amdfw.rom $(OPT_SPL_RW_AB_TABLE_FILE) \ $(OPT_SIGNED_AMDFW_B_POSITION) \ $(OPT_SIGNED_AMDFW_B_FILE) \ - --location $(shell printf "%#x" $(GLINDA_FW_B_POSITION)) \ + --location $(call _tohex,$(GLINDA_FW_B_POSITION)) \ --anywhere \ --output $@ -- cgit v1.2.3