From 993092039be26a4c822a05e345eada72654adf65 Mon Sep 17 00:00:00 2001 From: Felix Held Date: Tue, 13 Dec 2022 18:36:24 +0100 Subject: soc/amd/*/config: drop invalid comment Since commit 28e61f16341f ("device: Use __pci_0_00_0_config in config_of_soc()") config_of_soc() was changed form being an actual function to a macro for the __pci_0_00_0_config struct pointer generated by util/sconfig. This change didn't only improve linker optimizations, but also turned runtime errors into link-time errors, so it's guaranteed that __pci_0_00_0_config won't be NULL and config_of_soc() won't "return" NULL. Signed-off-by: Felix Held Change-Id: Id99ceaa9f7a70788da3f3068fb3da92d34fb6361 Reviewed-on: https://review.coreboot.org/c/coreboot/+/70732 Reviewed-by: Martin Roth Tested-by: build bot (Jenkins) Reviewed-by: Eric Lai Reviewed-by: Varshit Pandya Reviewed-by: Fred Reitberger --- src/soc/amd/glinda/config.c | 1 - 1 file changed, 1 deletion(-) (limited to 'src/soc/amd/glinda/config.c') diff --git a/src/soc/amd/glinda/config.c b/src/soc/amd/glinda/config.c index f667475302..371cfebaa3 100644 --- a/src/soc/amd/glinda/config.c +++ b/src/soc/amd/glinda/config.c @@ -6,7 +6,6 @@ const struct soc_amd_common_config *soc_get_common_config(void) { - /* config_of_soc calls die() internally if cfg was NULL, so no need to re-check */ const struct soc_amd_glinda_config *cfg = config_of_soc(); return &cfg->common_config; } -- cgit v1.2.3