From db3337d9297d1f1d7759ffaa846115f946701906 Mon Sep 17 00:00:00 2001 From: Felix Held Date: Sat, 28 Aug 2021 00:01:45 +0200 Subject: soc/amd/common/fsp/Makefile: drop strip_quotes call in FSP-M size check No need to strip the quotes of the FSP-M file path in the size check and it's always a good idea to not remove the quotes around file paths that will get passed as parameters to shell programs so that spaces in the path can't cause malfunction. TEST=All cases still behave as expected for Mandolin. Signed-off-by: Felix Held Suggested-by: Nico Huber Change-Id: Ieeea84b5861f9d15b2472208432169dc8e3f0049 Reviewed-on: https://review.coreboot.org/c/coreboot/+/57218 Tested-by: build bot (Jenkins) Reviewed-by: Nico Huber --- src/soc/amd/common/fsp/Makefile.inc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/soc/amd/common') diff --git a/src/soc/amd/common/fsp/Makefile.inc b/src/soc/amd/common/fsp/Makefile.inc index ee5e1ac19a..eac9e0636d 100644 --- a/src/soc/amd/common/fsp/Makefile.inc +++ b/src/soc/amd/common/fsp/Makefile.inc @@ -11,7 +11,7 @@ ifeq ($(CONFIG_FSP_M_FILE),) $(info There's no FSP-M binary file specified. The resulting image won't boot successfully.) else ifeq ($(call int-gt,\ - $(call file-size,$(call strip_quotes,$(CONFIG_FSP_M_FILE)))\ + $(call file-size,$(CONFIG_FSP_M_FILE))\ $(shell printf "%d" $(CONFIG_FSP_M_SIZE))),\ 1) $(error FSP-M binary larger than FSP_M_FILE.) -- cgit v1.2.3