From e18a97813b9fccc26435837a77ec90e5711ce1f6 Mon Sep 17 00:00:00 2001 From: Felix Held Date: Tue, 16 Feb 2021 00:48:49 +0100 Subject: soc/amd/common/*/Kconfig: remove unneeded default n for bool options n is the default of bool Kconfig options, so no need to have that added to each option. Signed-off-by: Felix Held Change-Id: I8775d84caee6fda95eb7749e96090fe05417e764 Reviewed-on: https://review.coreboot.org/c/coreboot/+/50779 Reviewed-by: Marshall Dawson Reviewed-by: Paul Menzel Tested-by: build bot (Jenkins) --- src/soc/amd/common/block/acpi/Kconfig | 1 - src/soc/amd/common/block/acpimmio/Kconfig | 1 - src/soc/amd/common/block/alink/Kconfig | 1 - src/soc/amd/common/block/aoac/Kconfig | 1 - src/soc/amd/common/block/cpu/Kconfig | 5 ----- src/soc/amd/common/block/gpio_banks/Kconfig | 1 - src/soc/amd/common/block/graphics/Kconfig | 1 - src/soc/amd/common/block/hda/Kconfig | 1 - src/soc/amd/common/block/iommu/Kconfig | 1 - src/soc/amd/common/block/lpc/Kconfig | 5 ----- src/soc/amd/common/block/pci/Kconfig | 2 -- src/soc/amd/common/block/pi/Kconfig | 1 - src/soc/amd/common/block/psp/Kconfig | 4 ---- src/soc/amd/common/block/s3/Kconfig | 1 - src/soc/amd/common/block/sata/Kconfig | 1 - src/soc/amd/common/block/smbus/Kconfig | 1 - src/soc/amd/common/block/smi/Kconfig | 1 - src/soc/amd/common/block/smu/Kconfig | 1 - src/soc/amd/common/block/spi/Kconfig | 2 -- src/soc/amd/common/block/uart/Kconfig | 2 -- 20 files changed, 34 deletions(-) (limited to 'src/soc/amd/common/block') diff --git a/src/soc/amd/common/block/acpi/Kconfig b/src/soc/amd/common/block/acpi/Kconfig index 21961f792d..024b378e68 100644 --- a/src/soc/amd/common/block/acpi/Kconfig +++ b/src/soc/amd/common/block/acpi/Kconfig @@ -2,6 +2,5 @@ config SOC_AMD_COMMON_BLOCK_ACPI bool depends on SOC_AMD_COMMON_BLOCK_ACPIMMIO select ACPI_AMD_HARDWARE_SLEEP_VALUES - default n help Select this option to use the AcpiMmio ACPI registers. diff --git a/src/soc/amd/common/block/acpimmio/Kconfig b/src/soc/amd/common/block/acpimmio/Kconfig index f14cc0c227..d74a00bcb9 100644 --- a/src/soc/amd/common/block/acpimmio/Kconfig +++ b/src/soc/amd/common/block/acpimmio/Kconfig @@ -1,6 +1,5 @@ config SOC_AMD_COMMON_BLOCK_ACPIMMIO bool - default n help Select this option to enable hardware blocks in the AcpiMmio address space (0xfed8xxxx). diff --git a/src/soc/amd/common/block/alink/Kconfig b/src/soc/amd/common/block/alink/Kconfig index 75cf66f194..fb28858452 100644 --- a/src/soc/amd/common/block/alink/Kconfig +++ b/src/soc/amd/common/block/alink/Kconfig @@ -1,5 +1,4 @@ config SOC_AMD_COMMON_BLOCK_ALINK bool - default n help Select this option to access the FCH A-link configuration registers. diff --git a/src/soc/amd/common/block/aoac/Kconfig b/src/soc/amd/common/block/aoac/Kconfig index be9dc671bc..e779e7b43f 100644 --- a/src/soc/amd/common/block/aoac/Kconfig +++ b/src/soc/amd/common/block/aoac/Kconfig @@ -1,6 +1,5 @@ config SOC_AMD_COMMON_BLOCK_AOAC bool - default n help Select this option to add the common functions for the AOAC (always on, always connected) block to the build. diff --git a/src/soc/amd/common/block/cpu/Kconfig b/src/soc/amd/common/block/cpu/Kconfig index f418ee7cc5..851b09175d 100644 --- a/src/soc/amd/common/block/cpu/Kconfig +++ b/src/soc/amd/common/block/cpu/Kconfig @@ -1,6 +1,5 @@ config SOC_AMD_COMMON_BLOCK_CAR bool - default n help This option allows the SOC to use a standard AMD cache-as-ram (CAR) implementation. CAR setup is built into bootblock and teardown is @@ -14,7 +13,6 @@ config SOC_AMD_COMMON_BLOCK_CAR config SOC_AMD_COMMON_BLOCK_NONCAR bool - default n help From family 17h on AMD CPUs/APUs don't use cache as RAM (CAR) any more, since the RAM initialization is already done by the PSP when @@ -30,7 +28,6 @@ endif # SOC_AMD_COMMON_BLOCK_NONCAR config SOC_AMD_COMMON_BLOCK_SMM bool - default n help Add common SMM relocation and handler functionality to the build. @@ -39,7 +36,6 @@ config SOC_AMD_COMMON_BLOCK_TSC_FAM17H_19H select COLLECT_TIMESTAMPS_NO_TSC # selected use SoC-specific timestamp function select TSC_SYNC_LFENCE select UDELAY_TSC - default n help Select this option to add the common functions for getting the TSC frequency of AMD family 17h and 19h CPUs/APUs and to provide TSC- @@ -48,7 +44,6 @@ config SOC_AMD_COMMON_BLOCK_TSC_FAM17H_19H config SOC_AMD_COMMON_BLOCK_UCODE bool select SUPPORT_CPU_UCODE_IN_CBFS - default n help Builds in support for loading uCode. diff --git a/src/soc/amd/common/block/gpio_banks/Kconfig b/src/soc/amd/common/block/gpio_banks/Kconfig index 115aa2cc52..1efb1db643 100644 --- a/src/soc/amd/common/block/gpio_banks/Kconfig +++ b/src/soc/amd/common/block/gpio_banks/Kconfig @@ -1,7 +1,6 @@ config SOC_AMD_COMMON_BLOCK_BANKED_GPIOS bool depends on SOC_AMD_COMMON_BLOCK_ACPIMMIO - default n help Select this option to use the newer style banks of GPIO signals. These are at offsets +0x1500, +0x1600, and +0x1700 from the AcpiMmio diff --git a/src/soc/amd/common/block/graphics/Kconfig b/src/soc/amd/common/block/graphics/Kconfig index 4cda353c5f..c277a0b23f 100644 --- a/src/soc/amd/common/block/graphics/Kconfig +++ b/src/soc/amd/common/block/graphics/Kconfig @@ -1,6 +1,5 @@ config SOC_AMD_COMMON_BLOCK_GRAPHICS bool - default n help Select this option to use AMD common graphics driver support. diff --git a/src/soc/amd/common/block/hda/Kconfig b/src/soc/amd/common/block/hda/Kconfig index 775de2fd8c..4c83b1c62a 100644 --- a/src/soc/amd/common/block/hda/Kconfig +++ b/src/soc/amd/common/block/hda/Kconfig @@ -1,6 +1,5 @@ config SOC_AMD_COMMON_BLOCK_HDA bool - default n help Select this option to use AMD common High Definition Audio driver support. diff --git a/src/soc/amd/common/block/iommu/Kconfig b/src/soc/amd/common/block/iommu/Kconfig index 4580400a7c..521bf8ab59 100644 --- a/src/soc/amd/common/block/iommu/Kconfig +++ b/src/soc/amd/common/block/iommu/Kconfig @@ -1,5 +1,4 @@ config SOC_AMD_COMMON_BLOCK_IOMMU bool - default n help Select this option to use AMD common IOMMU support. diff --git a/src/soc/amd/common/block/lpc/Kconfig b/src/soc/amd/common/block/lpc/Kconfig index 3aaccf344d..6ea34fba19 100644 --- a/src/soc/amd/common/block/lpc/Kconfig +++ b/src/soc/amd/common/block/lpc/Kconfig @@ -1,18 +1,15 @@ config SOC_AMD_COMMON_BLOCK_LPC bool - default n help Select this option to use the traditional LPC-ISA bridge at D14F3. config PROVIDES_ROM_SHARING bool - default n help Select this option if the LPC bridge supports ROM sharing. config SOC_AMD_COMMON_BLOCK_HAS_ESPI bool - default n help Select this option if platform supports eSPI using D14F3 configuration registers. @@ -20,7 +17,6 @@ config SOC_AMD_COMMON_BLOCK_HAS_ESPI config SOC_AMD_COMMON_BLOCK_USE_ESPI bool depends on SOC_AMD_COMMON_BLOCK_HAS_ESPI - default n help Select this option if mainboard uses eSPI instead of LPC (if supported by platform). @@ -28,4 +24,3 @@ config SOC_AMD_COMMON_BLOCK_USE_ESPI config SOC_AMD_COMMON_BLOCK_HAS_ESPI_SUB_DECODE bool depends on SOC_AMD_COMMON_BLOCK_HAS_ESPI - default n diff --git a/src/soc/amd/common/block/pci/Kconfig b/src/soc/amd/common/block/pci/Kconfig index a59d87eb54..4af0aa0d64 100644 --- a/src/soc/amd/common/block/pci/Kconfig +++ b/src/soc/amd/common/block/pci/Kconfig @@ -1,6 +1,5 @@ config SOC_AMD_COMMON_BLOCK_PCI bool - default n select SOC_AMD_COMMON_BLOCK_PCI_MMCONF help This option builds functions used to program PCI interrupt @@ -8,7 +7,6 @@ config SOC_AMD_COMMON_BLOCK_PCI config SOC_AMD_COMMON_BLOCK_PCI_MMCONF bool - default n help Selecting this option adds the AMD-common enable_pci_mmconf function to the build. diff --git a/src/soc/amd/common/block/pi/Kconfig b/src/soc/amd/common/block/pi/Kconfig index cf8c79ae50..d2a2a6ad9b 100644 --- a/src/soc/amd/common/block/pi/Kconfig +++ b/src/soc/amd/common/block/pi/Kconfig @@ -1,7 +1,6 @@ config SOC_AMD_COMMON_BLOCK_PI bool select HAVE_DEBUG_RAM_SETUP - default n help This option builds functions that interface AMD's AGESA reference code packaged in the binaryPI form. diff --git a/src/soc/amd/common/block/psp/Kconfig b/src/soc/amd/common/block/psp/Kconfig index 85ec9872a9..c5ec56015b 100644 --- a/src/soc/amd/common/block/psp/Kconfig +++ b/src/soc/amd/common/block/psp/Kconfig @@ -1,6 +1,5 @@ config SOC_AMD_COMMON_BLOCK_PSP bool - default n help This option builds in the Platform Security Processor initialization functions. Do not select this directly in SoC code, select @@ -8,21 +7,18 @@ config SOC_AMD_COMMON_BLOCK_PSP config SOC_AMD_COMMON_BLOCK_PSP_GEN1 bool - default n select SOC_AMD_COMMON_BLOCK_PSP help Used by the PSP in AMD systems before family 17h, e.g. stoneyridge. config SOC_AMD_COMMON_BLOCK_PSP_GEN2 bool - default n select SOC_AMD_COMMON_BLOCK_PSP help Used by the PSP in AMD family 17h, 19h and possibly newer CPUs. config SOC_AMD_PSP_SELECTABLE_SMU_FW bool - default n help Some PSP implementations allow storing SMU firmware into cbfs and calling the PSP to load the blobs at the proper time. diff --git a/src/soc/amd/common/block/s3/Kconfig b/src/soc/amd/common/block/s3/Kconfig index ebc1695d9b..797a59864a 100644 --- a/src/soc/amd/common/block/s3/Kconfig +++ b/src/soc/amd/common/block/s3/Kconfig @@ -1,6 +1,5 @@ config SOC_AMD_COMMON_BLOCK_S3 bool - default n depends on SOC_AMD_COMMON_BLOCK_ACPI select CACHE_MRC_SETTINGS select MRC_WRITE_NV_LATE diff --git a/src/soc/amd/common/block/sata/Kconfig b/src/soc/amd/common/block/sata/Kconfig index 0c3d5bc0a1..25aef1f589 100644 --- a/src/soc/amd/common/block/sata/Kconfig +++ b/src/soc/amd/common/block/sata/Kconfig @@ -1,5 +1,4 @@ config SOC_AMD_COMMON_BLOCK_SATA bool - default n help Select this option to use AMD common SATA driver support. diff --git a/src/soc/amd/common/block/smbus/Kconfig b/src/soc/amd/common/block/smbus/Kconfig index dd54b638ea..194cf4ff1a 100644 --- a/src/soc/amd/common/block/smbus/Kconfig +++ b/src/soc/amd/common/block/smbus/Kconfig @@ -1,5 +1,4 @@ config SOC_AMD_COMMON_BLOCK_SMBUS bool - default n help Select this option to add FCH SMBus controller functions to the build. diff --git a/src/soc/amd/common/block/smi/Kconfig b/src/soc/amd/common/block/smi/Kconfig index 1b05b14f33..b2054371cd 100644 --- a/src/soc/amd/common/block/smi/Kconfig +++ b/src/soc/amd/common/block/smi/Kconfig @@ -1,6 +1,5 @@ config SOC_AMD_COMMON_BLOCK_SMI bool - default n help Select this option to add the common functions for setting up the SMI configuration to the build. diff --git a/src/soc/amd/common/block/smu/Kconfig b/src/soc/amd/common/block/smu/Kconfig index 60c231fae8..fe2687ad97 100644 --- a/src/soc/amd/common/block/smu/Kconfig +++ b/src/soc/amd/common/block/smu/Kconfig @@ -1,5 +1,4 @@ config SOC_AMD_COMMON_BLOCK_SMU bool - default n help Select this option to add functions to communicate with the SMU to the build. diff --git a/src/soc/amd/common/block/spi/Kconfig b/src/soc/amd/common/block/spi/Kconfig index c8f6d1ecf9..fa24f8308c 100644 --- a/src/soc/amd/common/block/spi/Kconfig +++ b/src/soc/amd/common/block/spi/Kconfig @@ -1,6 +1,5 @@ config SOC_AMD_COMMON_BLOCK_SPI bool - default n help Select this option to add FCH SPI controller functions to the build. This overwrites the structure spi_flash_ops to use FCH SPI code @@ -8,7 +7,6 @@ config SOC_AMD_COMMON_BLOCK_SPI config SOC_AMD_COMMON_BLOCK_SPI_DEBUG bool - default n config EFS_SPI_READ_MODE int diff --git a/src/soc/amd/common/block/uart/Kconfig b/src/soc/amd/common/block/uart/Kconfig index c117dccc1a..438fde057a 100644 --- a/src/soc/amd/common/block/uart/Kconfig +++ b/src/soc/amd/common/block/uart/Kconfig @@ -1,6 +1,5 @@ config SOC_AMD_COMMON_BLOCK_UART bool - default n help Select this option to add the common functions for setting up the UART configuration to the build. @@ -9,7 +8,6 @@ if SOC_AMD_COMMON_BLOCK_UART config AMD_SOC_CONSOLE_UART bool "Use integrated AMD SoC UART controller for console" - default n select DRIVERS_UART_8250MEM select DRIVERS_UART_8250MEM_32 select NO_UART_ON_SUPERIO -- cgit v1.2.3