From 0d2c0019e284aea3b1889579782495afb6e52daf Mon Sep 17 00:00:00 2001 From: Felix Held Date: Mon, 12 Apr 2021 23:44:14 +0200 Subject: soc/amd/picasso/romstage: factor out chipset state saving functionality Since Cezanne needs the exact same code, move it to the common directory and add a Kconfig option to add this functionality to the build. Signed-off-by: Felix Held Change-Id: I04c4295071a3df7afcb4dfd5435b11fb0bf6963f Reviewed-on: https://review.coreboot.org/c/coreboot/+/52272 Tested-by: build bot (Jenkins) Reviewed-by: Arthur Heymans Reviewed-by: Raul Rangel --- src/soc/amd/common/block/include/amdblocks/pmlib.h | 3 +++ src/soc/amd/common/block/pm/Kconfig | 6 +++++ src/soc/amd/common/block/pm/Makefile.inc | 2 ++ src/soc/amd/common/block/pm/chipset_state.c | 27 ++++++++++++++++++++++ 4 files changed, 38 insertions(+) create mode 100644 src/soc/amd/common/block/pm/chipset_state.c (limited to 'src/soc/amd/common/block') diff --git a/src/soc/amd/common/block/include/amdblocks/pmlib.h b/src/soc/amd/common/block/include/amdblocks/pmlib.h index c778664a49..d9b80a29d1 100644 --- a/src/soc/amd/common/block/include/amdblocks/pmlib.h +++ b/src/soc/amd/common/block/include/amdblocks/pmlib.h @@ -17,4 +17,7 @@ enum { */ void pm_set_power_failure_state(void); +/* stash ACPI PM/GPE and GPIO wake state before FSP-M call */ +void fill_chipset_state(void); + #endif /* SOC_AMD_COMMON_BLOCK_PMLIB_H */ diff --git a/src/soc/amd/common/block/pm/Kconfig b/src/soc/amd/common/block/pm/Kconfig index c976d017ec..e250bf0a2b 100644 --- a/src/soc/amd/common/block/pm/Kconfig +++ b/src/soc/amd/common/block/pm/Kconfig @@ -10,4 +10,10 @@ if SOC_AMD_COMMON_BLOCK_PM config POWER_STATE_DEFAULT_ON_AFTER_FAILURE default y +config SOC_AMD_COMMON_BLOCK_PM_CHIPSET_STATE_SAVE + bool + help + Add common functionality to write CBMEM_ID_POWER_STATE for AMD + platforms that use FSP for hardware initialization. + endif # SOC_AMD_COMMON_BLOCK_PM diff --git a/src/soc/amd/common/block/pm/Makefile.inc b/src/soc/amd/common/block/pm/Makefile.inc index f465e99ec1..f016a9db02 100644 --- a/src/soc/amd/common/block/pm/Makefile.inc +++ b/src/soc/amd/common/block/pm/Makefile.inc @@ -1 +1,3 @@ bootblock-$(CONFIG_SOC_AMD_COMMON_BLOCK_PM) += pmlib.c + +romstage-$(CONFIG_SOC_AMD_COMMON_BLOCK_PM_CHIPSET_STATE_SAVE) += chipset_state.c diff --git a/src/soc/amd/common/block/pm/chipset_state.c b/src/soc/amd/common/block/pm/chipset_state.c new file mode 100644 index 0000000000..3a4a0ba506 --- /dev/null +++ b/src/soc/amd/common/block/pm/chipset_state.c @@ -0,0 +1,27 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ + +#include +#include +#include +#include +#include + +static struct chipset_power_state chipset_state; + +void fill_chipset_state(void) +{ + acpi_fill_pm_gpe_state(&chipset_state.gpe_state); + gpio_fill_wake_state(&chipset_state.gpio_state); +} + +static void add_chipset_state_cbmem(int unused) +{ + struct chipset_power_state *state; + + state = cbmem_add(CBMEM_ID_POWER_STATE, sizeof(*state)); + + if (state) + memcpy(state, &chipset_state, sizeof(*state)); +} + +ROMSTAGE_CBMEM_INIT_HOOK(add_chipset_state_cbmem); -- cgit v1.2.3