From 01792e353b62ef8d7e9bea7e42e7449d3120aab8 Mon Sep 17 00:00:00 2001 From: Raul E Rangel Date: Mon, 26 Apr 2021 13:52:38 -0600 Subject: soc/amd/common: Remove eSPI decode workaround We no longer lock up if we clear the port 80 bit. I'm assuming this was fixed when we configured the PSP to no longer setup eSPI. BUG=b:183974365 TEST=Boot guybrush to OS Signed-off-by: Raul E Rangel Change-Id: I1530d08974d42e0b06eb783521dea32fca752d85 Reviewed-on: https://review.coreboot.org/c/coreboot/+/52677 Tested-by: build bot (Jenkins) Reviewed-by: Marshall Dawson Reviewed-by: Martin Roth --- src/soc/amd/common/block/lpc/espi_util.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) (limited to 'src/soc/amd/common/block') diff --git a/src/soc/amd/common/block/lpc/espi_util.c b/src/soc/amd/common/block/lpc/espi_util.c index 82f2a85b1c..7752eb5670 100644 --- a/src/soc/amd/common/block/lpc/espi_util.c +++ b/src/soc/amd/common/block/lpc/espi_util.c @@ -103,11 +103,7 @@ static void espi_clear_decodes(void) unsigned int idx; /* First turn off all enable bits, then zero base, range, and size registers */ - /* - * There is currently a bug where the SMU will lock up at times if the port80h enable - * bit is cleared. See b/183974365 - */ - espi_write16(ESPI_DECODE, (espi_read16(ESPI_DECODE) & ESPI_DECODE_IO_0x80_EN)); + espi_write16(ESPI_DECODE, 0); for (idx = 0; idx < ESPI_GENERIC_IO_WIN_COUNT; idx++) { espi_write16(ESPI_IO_RANGE_BASE(idx), 0); -- cgit v1.2.3