From 390a28057cddc89995c23aa75f8abc4b6cf44028 Mon Sep 17 00:00:00 2001 From: Felix Held Date: Thu, 21 Oct 2021 03:13:42 +0200 Subject: soc/amd/common: move FCH IOAPIC and HPET init from SMBUs to LPC device Despite the SMBus device being function 0 of the FCH PCI device, the MMIO resource of the FCH IOAPIC is on the LPC device which is function 3 of the same PCI device, so move the FCH IOAPIC initialization code to the LPC device. Since the HPET was enabled in the same function, also move it to the LPC device initialization. TEST=On Mandolin both IOAPICs are still correctly detected by Linux. Signed-off-by: Felix Held Change-Id: I585afd463c1c00cd87ced0617e7802503c5deba5 Reviewed-on: https://review.coreboot.org/c/coreboot/+/58334 Reviewed-by: Fred Reitberger Reviewed-by: Marshall Dawson Tested-by: build bot (Jenkins) --- src/soc/amd/common/block/smbus/sm.c | 10 ---------- 1 file changed, 10 deletions(-) (limited to 'src/soc/amd/common/block/smbus') diff --git a/src/soc/amd/common/block/smbus/sm.c b/src/soc/amd/common/block/smbus/sm.c index e8b7c0fce6..801a1543b4 100644 --- a/src/soc/amd/common/block/smbus/sm.c +++ b/src/soc/amd/common/block/smbus/sm.c @@ -1,20 +1,11 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include -#include #include #include #include #include #include -#include - -static void sm_init(struct device *dev) -{ - fch_enable_ioapic_decode(); - setup_ioapic(VIO_APIC_VADDR, FCH_IOAPIC_ID); - fch_configure_hpet(); -} static u32 get_sm_mmio(struct device *dev) { @@ -77,7 +68,6 @@ static struct device_operations smbus_ops = { .read_resources = noop_read_resources, .set_resources = noop_set_resources, .enable_resources = pci_dev_enable_resources, - .init = sm_init, .scan_bus = scan_smbus, .ops_pci = &pci_dev_ops_pci, .ops_smbus_bus = &lops_smbus_bus, -- cgit v1.2.3