From cce6d13aa733d9224dd538f60fed691e2fb2780b Mon Sep 17 00:00:00 2001 From: Jon Murphy Date: Wed, 20 Sep 2023 10:43:07 -0600 Subject: security/tpm: Remove unnecessary tss_common.h Remove the unnecessary tss_common.h header from the repo. tss_errors.h is a more appropriate place for the TPM_SUCCESS value, and the other define is only used by tpm_common.c and can be placed there. BUG=b:296439237 TEST=Builds Change-Id: I99cf90f244a75c1eeab5e9e1500e05c24ae0a8e5 Signed-off-by: Jon Murphy Reviewed-on: https://review.coreboot.org/c/coreboot/+/78033 Reviewed-by: Tim Van Patten Tested-by: build bot (Jenkins) Reviewed-by: Julius Werner --- src/security/tpm/tss/common/tss_common.h | 11 ----------- src/security/tpm/tss/tcg-1.2/tss_structures.h | 2 +- src/security/tpm/tss/tcg-2.0/tss_structures.h | 2 +- 3 files changed, 2 insertions(+), 13 deletions(-) delete mode 100644 src/security/tpm/tss/common/tss_common.h (limited to 'src/security/tpm/tss') diff --git a/src/security/tpm/tss/common/tss_common.h b/src/security/tpm/tss/common/tss_common.h deleted file mode 100644 index 419e429349..0000000000 --- a/src/security/tpm/tss/common/tss_common.h +++ /dev/null @@ -1,11 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ - -#ifndef TCG_TSS_COMMON_H_ -#define TCG_TSS_COMMON_H_ - -#include - -#define TPM_PCR_MINIMUM_DIGEST_SIZE 20 -#define TPM_SUCCESS ((uint32_t)0x00000000) - -#endif /* TCG_TSS_COMMON_H_ */ diff --git a/src/security/tpm/tss/tcg-1.2/tss_structures.h b/src/security/tpm/tss/tcg-1.2/tss_structures.h index 689bb4bbf9..65b48f8f2e 100644 --- a/src/security/tpm/tss/tcg-1.2/tss_structures.h +++ b/src/security/tpm/tss/tcg-1.2/tss_structures.h @@ -8,7 +8,7 @@ #define TCG1_TSS_STRUCTURES_H_ #include -#include "../common/tss_common.h" +#include #define TPM_MAX_COMMAND_SIZE 4096 #define TPM_LARGE_ENOUGH_COMMAND_SIZE 256 /* saves space in the firmware */ diff --git a/src/security/tpm/tss/tcg-2.0/tss_structures.h b/src/security/tpm/tss/tcg-2.0/tss_structures.h index cb0283045f..a73f4c48e6 100644 --- a/src/security/tpm/tss/tcg-2.0/tss_structures.h +++ b/src/security/tpm/tss/tcg-2.0/tss_structures.h @@ -8,7 +8,7 @@ * constants and structures needed for functions used in coreboot. */ #include -#include "../common/tss_common.h" +#include /* This should be plenty for what firmware needs. */ #define TPM_BUFFER_SIZE 256 -- cgit v1.2.3