From ead8751367867b798cea0709628c8eda780f20c8 Mon Sep 17 00:00:00 2001 From: Timothy Pearson Date: Fri, 20 Feb 2015 12:47:52 -0600 Subject: cpu/amd/model_10xxx: Refactor model detection to reduce code duplication Moved mctGetLogicalCPUID() to a separate file and made it available in both romstage and ramstage. Change-Id: I959c1caa8f796947b627a7b379c37d7307e2898e Signed-off-by: Timothy Pearson Reviewed-on: http://review.coreboot.org/8499 Tested-by: build bot (Jenkins) Reviewed-by: Paul Menzel Reviewed-by: Nicolas Reinecke Reviewed-by: Alexandru Gagniuc --- src/northbridge/amd/amdfam10/Makefile.inc | 2 + src/northbridge/amd/amdfam10/amdfam10_util.c | 109 ++++++++++++++++++++++++++ src/northbridge/amd/amdfam10/raminit_amdmct.c | 76 ------------------ 3 files changed, 111 insertions(+), 76 deletions(-) create mode 100644 src/northbridge/amd/amdfam10/amdfam10_util.c (limited to 'src/northbridge') diff --git a/src/northbridge/amd/amdfam10/Makefile.inc b/src/northbridge/amd/amdfam10/Makefile.inc index ef4bef4654..fdbfa1222a 100644 --- a/src/northbridge/amd/amdfam10/Makefile.inc +++ b/src/northbridge/amd/amdfam10/Makefile.inc @@ -1,5 +1,7 @@ ramstage-y += northbridge.c ramstage-y += misc_control.c +romstage-y += amdfam10_util.c +ramstage-y += amdfam10_util.c ramstage-$(CONFIG_HAVE_ACPI_TABLES) += acpi.c diff --git a/src/northbridge/amd/amdfam10/amdfam10_util.c b/src/northbridge/amd/amdfam10/amdfam10_util.c new file mode 100644 index 0000000000..2726b280be --- /dev/null +++ b/src/northbridge/amd/amdfam10/amdfam10_util.c @@ -0,0 +1,109 @@ +/* + * This file is part of the coreboot project. + * + * Copyright (C) 2015 Timothy Pearson , Raptor Engineering + * Copyright (C) 2007 Advanced Micro Devices, Inc. + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; version 2 of the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program; if not, write to the Free Software + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA + */ + +#include + +#include +#include +#include + +#ifndef __PRE_RAM__ +#include +#include +u32 Get_NB32(u32 dev, u32 reg) +{ + return pci_read_config32(dev_find_slot(0, PCI_DEV2DEVFN(dev)), reg); +} +#endif + +u32 mctGetLogicalCPUID(u32 Node) +{ + /* Converts the CPUID to a logical ID MASK that is used to check + CPU version support versions */ + u32 dev; + u32 val, valx; + u32 family, model, stepping; + u32 ret; + + if (Node == 0xFF) { /* current node */ + val = cpuid_eax(0x80000001); + } else { + dev = PA_NBMISC(Node); + val = Get_NB32(dev, 0xfc); + } + + family = ((val >> 8) & 0x0f) + ((val >> 20) & 0xff); + model = ((val >> 4) & 0x0f) | ((val >> (16-4)) & 0xf0); + stepping = val & 0x0f; + + valx = (family << 12) | (model << 4) | (stepping); + + switch (valx) { + case 0x10000: + ret = AMD_DR_A0A; + break; + case 0x10001: + ret = AMD_DR_A1B; + break; + case 0x10002: + ret = AMD_DR_A2; + break; + case 0x10020: + ret = AMD_DR_B0; + break; + case 0x10021: + ret = AMD_DR_B1; + break; + case 0x10022: + ret = AMD_DR_B2; + break; + case 0x10023: + ret = AMD_DR_B3; + break; + case 0x10042: + ret = AMD_RB_C2; + break; + case 0x10043: + ret = AMD_RB_C3; + break; + case 0x10062: + ret = AMD_DA_C2; + break; + case 0x10063: + ret = AMD_DA_C3; + break; + case 0x10080: + ret = AMD_HY_D0; + break; + case 0x10081: + case 0x10091: + ret = AMD_HY_D1; + break; + case 0x100a0: + ret = AMD_PH_E0; + break; + default: + /* FIXME: mabe we should die() here. */ + printk(BIOS_ERR, "FIXME! CPU Version unknown or not supported! \n"); + ret = 0; + } + + return ret; +} diff --git a/src/northbridge/amd/amdfam10/raminit_amdmct.c b/src/northbridge/amd/amdfam10/raminit_amdmct.c index 6398506049..02dc956306 100644 --- a/src/northbridge/amd/amdfam10/raminit_amdmct.c +++ b/src/northbridge/amd/amdfam10/raminit_amdmct.c @@ -187,82 +187,6 @@ void mctGet_DIMMAddr(struct DCTStatStruc *pDCTstat, u32 node) } - -u32 mctGetLogicalCPUID(u32 Node) -{ - /* FIXME: Move this to a more generic place. Maybe to the CPU code */ - /* Converts the CPUID to a logical ID MASK that is used to check - CPU version support versions */ - u32 dev; - u32 val, valx; - u32 family, model, stepping; - u32 ret; - - if (Node == 0xFF) { /* current node */ - val = cpuid_eax(0x80000001); - } else { - dev = PA_NBMISC(Node); - val = Get_NB32(dev, 0xfc); - } - - family = ((val >> 8) & 0x0f) + ((val >> 20) & 0xff); - model = ((val >> 4) & 0x0f) | ((val >> (16-4)) & 0xf0); - stepping = val & 0x0f; - - valx = (family << 12) | (model << 4) | (stepping); - - switch (valx) { - case 0x10000: - ret = AMD_DR_A0A; - break; - case 0x10001: - ret = AMD_DR_A1B; - break; - case 0x10002: - ret = AMD_DR_A2; - break; - case 0x10020: - ret = AMD_DR_B0; - break; - case 0x10021: - ret = AMD_DR_B1; - break; - case 0x10022: - ret = AMD_DR_B2; - break; - case 0x10023: - ret = AMD_DR_B3; - break; - case 0x10042: - ret = AMD_RB_C2; - break; - case 0x10043: - ret = AMD_RB_C3; - break; - case 0x10062: - ret = AMD_DA_C2; - break; - case 0x10063: - ret = AMD_DA_C3; - break; - case 0x10080: - ret = AMD_HY_D0; - break; - case 0x10081: - ret = AMD_HY_D1; - break; - case 0x100a0: - ret = AMD_PH_E0; - break; - default: - /* FIXME: mabe we should die() here. */ - printk(BIOS_ERR, "FIXME! CPU Version unknown or not supported! \n"); - ret = 0; - } - - return ret; -} - static u8 mctGetProcessorPackageType(void) { /* FIXME: I guess this belongs wherever mctGetLogicalCPUID ends up ? */ u32 BrandId = cpuid_ebx(0x80000001); -- cgit v1.2.3