From b50602007656962ab6717d63d2f9d83e5c00dacf Mon Sep 17 00:00:00 2001 From: Julius Werner Date: Tue, 6 Feb 2024 22:38:14 -0800 Subject: commonlib: Change GCD function to always use 64 bits It seems that we have some applications where we need to calculate a GCD in 64 bits. Now, we could instantiate the algorithm multiple times for different bit width combinations to be able to use the most efficient one for each problem... but considering that the function usually only gets called once per callsite per stage, and that software emulation of 64-bit division on 32-bit systems doesn't take *that* long either, we would probably usually be paying more time loading the second instance of the function than we save with faster divisions. So let's just make things easy and always do it in 64-bit and then nobody has to spend time thinking on which version to call. Change-Id: I028361444c4048a0d76ba4f80c7334a9d9983c87 Signed-off-by: Julius Werner Reviewed-on: https://review.coreboot.org/c/coreboot/+/80319 Reviewed-by: Nico Huber Tested-by: build bot (Jenkins) Reviewed-by: Yidi Lin --- src/northbridge/intel/ironlake/quickpath.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'src/northbridge') diff --git a/src/northbridge/intel/ironlake/quickpath.c b/src/northbridge/intel/ironlake/quickpath.c index eb79347875..aac852ab11 100644 --- a/src/northbridge/intel/ironlake/quickpath.c +++ b/src/northbridge/intel/ironlake/quickpath.c @@ -19,7 +19,7 @@ static inline int div_roundup(int a, int b) static u32 lcm(u32 a, u32 b) { - return (a * b) / gcd32(a, b); + return (a * b) / gcd(a, b); } struct stru1 { @@ -49,7 +49,7 @@ compute_frequence_ratios(struct raminfo *info, u16 freq1, u16 freq2, int freq_max_reduced; int freq3, freq4; - g = gcd32(freq1, freq2); + g = gcd(freq1, freq2); freq1_reduced = freq1 / g; freq2_reduced = freq2 / g; freq_min_reduced = MIN(freq1_reduced, freq2_reduced); -- cgit v1.2.3