From 9b4c888f7bb91ea5034802ab381f87c4c9729ad9 Mon Sep 17 00:00:00 2001 From: Timothy Pearson Date: Tue, 17 Jan 2017 18:27:42 -0600 Subject: nb/amd/ddr3: Make the maximum CDD a signed value max_cdd_we_delta should be signed to allow for negative CDD. Found-by: Coverity Scan #1347355 Change-Id: Iaccd1021680296d169c26c25e339f83fbd7cc065 Signed-off-by: Timothy Pearson Reviewed-on: https://review.coreboot.org/18162 Tested-by: build bot (Jenkins) Tested-by: Raptor Engineering Automated Test Stand Reviewed-by: Paul Menzel Reviewed-by: Nico Huber --- src/northbridge/amd/amdmct/mct_ddr3/mct_d.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/northbridge') diff --git a/src/northbridge/amd/amdmct/mct_ddr3/mct_d.c b/src/northbridge/amd/amdmct/mct_ddr3/mct_d.c index b64ad54711..1ac91a1fb2 100644 --- a/src/northbridge/amd/amdmct/mct_ddr3/mct_d.c +++ b/src/northbridge/amd/amdmct/mct_ddr3/mct_d.c @@ -3027,7 +3027,7 @@ void fam15EnableTrainingMode(struct MCTStatStruc *pMCTstat, /* Disable training mode */ uint8_t lane; uint8_t dimm; - uint16_t max_cdd_we_delta; + int16_t max_cdd_we_delta; int16_t cdd_trwtto_we_delta; uint8_t receiver; uint8_t lane_count; -- cgit v1.2.3