From c51dc44bf2b76ac47b83ee76bee3357ce4b173de Mon Sep 17 00:00:00 2001 From: Stefan Reinauer Date: Wed, 7 Apr 2010 01:44:04 +0000 Subject: "no warnings day" last round for today. still warnings - help appreciated. Signed-off-by: Stefan Reinauer Acked-by: Stefan Reinauer git-svn-id: svn://svn.coreboot.org/coreboot/trunk@5363 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1 --- src/northbridge/via/cn400/cn400.h | 3 ++- src/northbridge/via/cn400/northbridge.c | 2 +- src/northbridge/via/vt8623/northbridge.c | 2 +- src/northbridge/via/vt8623/raminit.c | 2 +- src/northbridge/via/vx800/vx800.h | 2 +- src/northbridge/via/vx800/vx800_ide.c | 7 ++----- 6 files changed, 8 insertions(+), 10 deletions(-) (limited to 'src/northbridge/via') diff --git a/src/northbridge/via/cn400/cn400.h b/src/northbridge/via/cn400/cn400.h index 3c9e8fd52a..baa58a1206 100644 --- a/src/northbridge/via/cn400/cn400.h +++ b/src/northbridge/via/cn400/cn400.h @@ -19,7 +19,8 @@ */ #ifndef __PRE_RAM__ -static void cn400_noop(void) +// HACK +static inline void cn400_noop(device_t dev) { } #endif diff --git a/src/northbridge/via/cn400/northbridge.c b/src/northbridge/via/cn400/northbridge.c index 5aec00835f..f867427824 100644 --- a/src/northbridge/via/cn400/northbridge.c +++ b/src/northbridge/via/cn400/northbridge.c @@ -238,7 +238,7 @@ static void cn400_domain_set_resources(device_t dev) if (mc_dev) { unsigned long tomk, tolmk; unsigned char rambits; - int i, idx; + int idx; rambits = pci_read_config8(mc_dev, 0x47); tomk = rambits * 32 * 1024; diff --git a/src/northbridge/via/vt8623/northbridge.c b/src/northbridge/via/vt8623/northbridge.c index 3144395180..7d33e44236 100644 --- a/src/northbridge/via/vt8623/northbridge.c +++ b/src/northbridge/via/vt8623/northbridge.c @@ -105,7 +105,7 @@ static const struct pci_driver agp_driver __pci_driver = { static void vga_init(device_t dev) { // unsigned long fb; - msr_t clocks1,clocks2,instructions,setup; + //msr_t clocks1,clocks2,instructions,setup; printk(BIOS_DEBUG, "VGA random fixup ...\n"); pci_write_config8(dev, 0x04, 0x07); diff --git a/src/northbridge/via/vt8623/raminit.c b/src/northbridge/via/vt8623/raminit.c index 40338dae7e..f57127b3da 100644 --- a/src/northbridge/via/vt8623/raminit.c +++ b/src/northbridge/via/vt8623/raminit.c @@ -69,7 +69,7 @@ static void ddr_ram_setup(const struct mem_controller *ctrl) { device_t north = (device_t) 0; uint8_t b, c, bank; - uint16_t i,j; + uint16_t i; unsigned long bank_address; print_debug("vt8623 init starting\n"); diff --git a/src/northbridge/via/vx800/vx800.h b/src/northbridge/via/vx800/vx800.h index 5e1c4df205..1d832508ac 100644 --- a/src/northbridge/via/vx800/vx800.h +++ b/src/northbridge/via/vx800/vx800.h @@ -21,7 +21,7 @@ #define VX800_H 1 #ifndef __PRE_RAM__ -static void vx800_noop() +static inline void vx800_noop(device_t dev) { } #endif diff --git a/src/northbridge/via/vx800/vx800_ide.c b/src/northbridge/via/vx800/vx800_ide.c index b3d6bc2c02..b4c40d4e2f 100644 --- a/src/northbridge/via/vx800/vx800_ide.c +++ b/src/northbridge/via/vx800/vx800_ide.c @@ -166,13 +166,10 @@ static const idedevicepcitable[16 * 12] = { static void ide_init(struct device *dev) { - uint8_t enables, Rx89, RxC0; u8 i, data; - struct ATA_REG_INIT_TABLE *pEntry; printk(BIOS_INFO, "ide_init\n"); -#if 1 - /*these 3 lines help to keep interl back door for DID VID SUBID untouched */ + /* these 3 lines help to keep interl back door for DID VID SUBID untouched */ u16 data16_1, data16_2; data16_1 = pci_read_config16(dev, 0xba); data16_2 = pci_read_config16(dev, 0xbe); @@ -189,7 +186,7 @@ static void ide_init(struct device *dev) //these 2 lines help to keep interl back door for DID VID SUBID untouched pci_write_config16(dev, 0xba, data16_1); pci_write_config16(dev, 0xbe, data16_2); -#endif + /* Force interrupts to use compat mode. */ pci_write_config8(dev, PCI_INTERRUPT_PIN, 0x0); pci_write_config8(dev, PCI_INTERRUPT_LINE, 0xff); -- cgit v1.2.3