From f70475484769c6b7310446f084d4fecbf1a82f70 Mon Sep 17 00:00:00 2001 From: Patrick Rudolph Date: Sat, 12 Nov 2016 11:39:57 +0100 Subject: nb/intel/sandybridge/raminit: Get rid of fallback attempts Locking the PLL again once it's locked doesn't work. The MRC doesn't do this, for some reason. Remove fallback attempts of lowering DDR frequency. Change-Id: Iccb54fa7d7357a22182dd26bd5b49c4073c04dc9 Signed-off-by: Patrick Rudolph Reviewed-on: https://review.coreboot.org/17399 Tested-by: build bot (Jenkins) Reviewed-by: Martin Roth --- src/northbridge/intel/sandybridge/raminit.c | 21 +-------------------- 1 file changed, 1 insertion(+), 20 deletions(-) (limited to 'src/northbridge/intel') diff --git a/src/northbridge/intel/sandybridge/raminit.c b/src/northbridge/intel/sandybridge/raminit.c index 8123014e91..65d4348c65 100644 --- a/src/northbridge/intel/sandybridge/raminit.c +++ b/src/northbridge/intel/sandybridge/raminit.c @@ -834,11 +834,8 @@ static void dram_freq(ramctr_timing * ctrl) */ reg1 = MCHBAR32(0x5e04); val2 = (u8) reg1; - if (val2 == FRQ) { - printk(BIOS_DEBUG, "MCU frequency is set at : %d MHz\n", - (1000 << 8) / ctrl->tCK); + if (val2) return; - } /* Step 2 - Select frequency in the MCU */ reg1 = FRQ; @@ -4275,22 +4272,6 @@ void init_dram_ddr3(spd_raw_data *spds, int mobile, int min_tck, err = try_init_dram_ddr3(&ctrl, fast_boot, s3resume, me_uma_size); } - if (err && (ctrl.tCK < TCK_400MHZ)) { - /* fallback: lower clock frequency */ - printk(BIOS_ERR, "RAM training failed, trying fallback.\n"); - printram("Decreasing clock frequency.\n"); - ctrl.tCK++; - err = try_init_dram_ddr3(&ctrl, fast_boot, s3resume, me_uma_size); - } - - if (err && (ctrl.tCK < TCK_400MHZ)) { - /* fallback: lower clock frequency */ - printk(BIOS_ERR, "RAM training failed, trying fallback.\n"); - printram("Decreasing clock frequency.\n"); - ctrl.tCK++; - err = try_init_dram_ddr3(&ctrl, fast_boot, s3resume, me_uma_size); - } - if (err) { /* fallback: disable failing channel */ printk(BIOS_ERR, "RAM training failed, trying fallback.\n"); -- cgit v1.2.3