From 70dc0a8cc34dfa66473d00fc7fffdc71d38b4347 Mon Sep 17 00:00:00 2001 From: Angel Pons Date: Fri, 26 Mar 2021 23:23:22 +0100 Subject: nb/intel/x4x/dq_dqs.c: Avoid breaking strings over multiple lines Breaking strings across multiple lines hurts greppability. Refactor the code a bit to drop one indentation level, and then reflow the strings. Change-Id: I0accdfd0d2c5f58e4da493ba0d4b5c6a067d92c3 Signed-off-by: Angel Pons Reviewed-on: https://review.coreboot.org/c/coreboot/+/51876 Reviewed-by: Nico Huber Tested-by: build bot (Jenkins) --- src/northbridge/intel/x4x/dq_dqs.c | 28 +++++++++++----------------- 1 file changed, 11 insertions(+), 17 deletions(-) (limited to 'src/northbridge/intel/x4x') diff --git a/src/northbridge/intel/x4x/dq_dqs.c b/src/northbridge/intel/x4x/dq_dqs.c index afb77424af..6045f3bf41 100644 --- a/src/northbridge/intel/x4x/dq_dqs.c +++ b/src/northbridge/intel/x4x/dq_dqs.c @@ -656,16 +656,13 @@ static enum cb_err increment_to_dqs_edge(struct sysinfo *s, u8 channel, u8 rank) lane, dq_sample[lane]); - if (dq_sample[lane] > 0) { - if (decrement_dq_dqs(s, &dqs_setting[lane])) { - printk(BIOS_EMERG, - "DQS setting channel%d, " - "lane %d reached a minimum!\n", - channel, lane); - return CB_ERR; - } - } else { + if (dq_sample[lane] == 0) { bytelane_ok |= (1 << lane); + } else if (decrement_dq_dqs(s, &dqs_setting[lane])) { + printk(BIOS_EMERG, + "DQS setting channel%d, lane %d reached a minimum!\n", + channel, lane); + return CB_ERR; } dqsset(channel, lane, &dqs_setting[lane]); } @@ -695,14 +692,11 @@ static enum cb_err increment_to_dqs_edge(struct sysinfo *s, u8 channel, u8 rank) if (dq_sample[lane] == N_SAMPLES) { bytelane_ok |= (1 << lane); - } else { - if (increment_dq_dqs(s, &dqs_setting[lane])) { - printk(BIOS_EMERG, - "DQS setting channel%d, " - "lane %d reached a maximum!\n", - channel, lane); - return CB_ERR; - } + } else if (increment_dq_dqs(s, &dqs_setting[lane])) { + printk(BIOS_EMERG, + "DQS setting channel%d, lane %d reached a maximum!\n", + channel, lane); + return CB_ERR; } dqsset(channel, lane, &dqs_setting[lane]); } -- cgit v1.2.3