From d10680bbbfc045627625ca0ce79e04491978cedf Mon Sep 17 00:00:00 2001 From: Jacob Garber Date: Tue, 11 Jun 2019 14:13:04 -0600 Subject: nb/intel/pineview: Remove unused code All the clocks are switched on anyway, so this series of if statements isn't needed. Change-Id: I654043fd6736caa6890fd697015c577ddaa7cd41 Signed-off-by: Jacob Garber Found-by: Coverity CID 13473{27-30} Reviewed-on: https://review.coreboot.org/c/coreboot/+/33408 Tested-by: build bot (Jenkins) Reviewed-by: HAOUAS Elyes Reviewed-by: Angel Pons --- src/northbridge/intel/pineview/raminit.c | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-) (limited to 'src/northbridge/intel/pineview') diff --git a/src/northbridge/intel/pineview/raminit.c b/src/northbridge/intel/pineview/raminit.c index 72063cbdad..1d24ea2217 100644 --- a/src/northbridge/intel/pineview/raminit.c +++ b/src/northbridge/intel/pineview/raminit.c @@ -1141,16 +1141,7 @@ static void sdram_dlltiming(struct sysinfo *s) MCHBAR8(0x1a8) = MCHBAR8(0x1a8) | 1; MCHBAR32(0x1a0) = 0x551803; - if (ONLY_DIMMA_IS_POPULATED(s->dimms, 0)) { - reg8 = 0x3c; - } else if (ONLY_DIMMB_IS_POPULATED(s->dimms, 0)) { - reg8 = 0x27; - } else if (BOTH_DIMMS_ARE_POPULATED(s->dimms, 0)) { - reg8 = 0x24; - } else { - // None - reg8 = 0x3f; - } + reg8 = 0x00; //switch all clocks on anyway MCHBAR32(0x5a0) = (MCHBAR32(0x5a0) & ~0x3f000000) | (reg8 << 24); -- cgit v1.2.3