From 8ab91d875b3572a1c9b50e2035edf996aa8727da Mon Sep 17 00:00:00 2001 From: Uwe Hermann Date: Tue, 18 Nov 2008 12:02:03 +0000 Subject: i810: Add some more comments, and especially add a list of tested BUFF_SC values for different DIMM configurations. This should be converted to a table or code later on and actually be used for BUFF_SC. Many thanks to Elia Yehuda for testing and collecting the table entries. Signed-off-by: Uwe Hermann Acked-by: Uwe Hermann git-svn-id: svn://svn.coreboot.org/coreboot/trunk@3759 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1 --- src/northbridge/intel/i82810/i82810.h | 19 +++++++++---------- 1 file changed, 9 insertions(+), 10 deletions(-) (limited to 'src/northbridge/intel/i82810/i82810.h') diff --git a/src/northbridge/intel/i82810/i82810.h b/src/northbridge/intel/i82810/i82810.h index e70b35c9a6..94993ec540 100644 --- a/src/northbridge/intel/i82810/i82810.h +++ b/src/northbridge/intel/i82810/i82810.h @@ -30,17 +30,16 @@ /* * PCI Configuration Registers. * - * Any addresses between 0x00 and 0xff not listed below are reserved and + * Any addresses between 0x50 and 0xff not listed below are reserved and * should not be touched. */ -/* TODO: Descriptions. */ -#define GMCHCFG 0x50 -#define PAM 0x51 -#define DRP 0x52 -#define DRAMT 0x53 -#define FDHC 0x58 +#define GMCHCFG 0x50 /* GMCH Configuration */ +#define PAM 0x51 /* Programmable Attributes */ +#define DRP 0x52 /* DRAM Row Population */ +#define DRAMT 0x53 /* DRAM Timing */ +#define FDHC 0x58 /* Fixed DRAM Hole Control */ #define SMRAM 0x70 /* System Management RAM Control */ -#define MISSC 0x72 -#define MISSC2 0x80 -#define BUFF_SC 0x92 +#define MISSC 0x72 /* Miscellaneous Control */ +#define MISSC2 0x80 /* Miscellaneous Control 2 */ +#define BUFF_SC 0x92 /* System Memory Buffer Strength Control */ -- cgit v1.2.3