From 562d6f30a0745b3da4c61974f8ac1b529dac9d80 Mon Sep 17 00:00:00 2001 From: Martin Roth Date: Thu, 16 Apr 2015 21:20:34 -0600 Subject: fsp platforms: consolidate FspNotify calls Consolidate the FspNotify calls into the FSP driver directory, using BOOT_STATE_INIT_ENTRY to set up the call times. Change-Id: I184ab234ebb9dcdeb8eece1537c12d03f227c25e Signed-off-by: Martin Roth Reviewed-on: http://review.coreboot.org/9780 Tested-by: build bot (Jenkins) Reviewed-by: Stefan Reinauer --- .../intel/fsp_sandybridge/northbridge.c | 23 ---------------------- 1 file changed, 23 deletions(-) (limited to 'src/northbridge/intel/fsp_sandybridge') diff --git a/src/northbridge/intel/fsp_sandybridge/northbridge.c b/src/northbridge/intel/fsp_sandybridge/northbridge.c index fac635df10..17e772329c 100644 --- a/src/northbridge/intel/fsp_sandybridge/northbridge.c +++ b/src/northbridge/intel/fsp_sandybridge/northbridge.c @@ -39,7 +39,6 @@ #include static int bridge_revision_id = -1; -static u8 finished_FSP_after_pci = 0; /* IGD UMA memory */ static uint64_t uma_memory_base = 0; @@ -372,31 +371,9 @@ static void enable_dev(device_t dev) } else if (dev->path.type == DEVICE_PATH_CPU_CLUSTER) { dev->ops = &cpu_bus_ops; } - - /* - * Notify FSP for PostPciEnumeration. - * This call needs to be done before resource allocation. - */ - if (!finished_FSP_after_pci) { - finished_FSP_after_pci = 1; - printk(BIOS_DEBUG, "FspNotify(EnumInitPhaseAfterPciEnumeration)\n"); - FspNotify(EnumInitPhaseAfterPciEnumeration); - printk(BIOS_DEBUG, - "Returned from FspNotify(EnumInitPhaseAfterPciEnumeration)\n\n"); - } -} - -static void finalize_chip(void *chip_info) -{ - /* Notify FSP for ReadyToBoot */ - printk(BIOS_DEBUG, "FspNotify(EnumInitPhaseReadyToBoot)\n"); - print_fsp_info(); - FspNotify(EnumInitPhaseReadyToBoot); - printk(BIOS_DEBUG, "Returned from FspNotify(EnumInitPhaseReadyToBoot)\n"); } struct chip_operations northbridge_intel_fsp_sandybridge_ops = { CHIP_NAME("Intel i7 (SandyBridge/IvyBridge) integrated Northbridge") .enable_dev = enable_dev, - .final = finalize_chip, }; -- cgit v1.2.3