From bdae93571b4d54a149023ac1e208cfdee7561411 Mon Sep 17 00:00:00 2001 From: Patrick Rudolph Date: Tue, 20 Jun 2017 17:54:53 +0200 Subject: nb/intel/common/gma_opregion: Use new method to update ASLS Use new GMA driver method to set ASLS. Change-Id: I872ff86a778497df76ad7f9b1b6910c4e7c5941f Signed-off-by: Patrick Rudolph Reviewed-on: https://review.coreboot.org/20283 Tested-by: build bot (Jenkins) Reviewed-by: Matt DeVillier Reviewed-by: Aaron Durbin --- src/northbridge/intel/common/gma_opregion.c | 15 ++------------- 1 file changed, 2 insertions(+), 13 deletions(-) (limited to 'src/northbridge/intel/common') diff --git a/src/northbridge/intel/common/gma_opregion.c b/src/northbridge/intel/common/gma_opregion.c index 7d4c3f1c05..43e7c16d3f 100644 --- a/src/northbridge/intel/common/gma_opregion.c +++ b/src/northbridge/intel/common/gma_opregion.c @@ -79,8 +79,6 @@ static enum cb_err init_opregion_vbt(igd_opregion_t *opregion) enum cb_err init_igd_opregion(igd_opregion_t *opregion) { enum cb_err ret; - device_t igd; - u16 reg16; memset((void *)opregion, 0, sizeof(igd_opregion_t)); @@ -119,17 +117,8 @@ enum cb_err init_igd_opregion(igd_opregion_t *opregion) if (ret != CB_SUCCESS) return ret; - /* TODO This needs to happen in S3 resume, too. - * Maybe it should move to the finalize handler - */ - igd = dev_find_slot(0, PCI_DEVFN(0x2, 0)); - pci_write_config32(igd, ASLS, (u32)opregion); - - /* Intel's Windows driver relies on this: */ - reg16 = pci_read_config16(igd, SWSCI); - reg16 &= ~GSSCIE; - reg16 |= SMISCISEL; - pci_write_config16(igd, SWSCI, reg16); + /* Write ASLS PCI register and prepare SWSCI register. */ + intel_gma_opregion_register((uintptr_t)opregion); return CB_SUCCESS; } -- cgit v1.2.3