From f170e71630bff4b181dbd5b209d9fb3f8ce35131 Mon Sep 17 00:00:00 2001 From: Arthur Heymans Date: Fri, 7 Apr 2017 09:24:02 +0200 Subject: nb/amdk8/(pre_)f.h: Don't declare global variable in header MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This is needed if one wants to use the header more than once. Change-Id: I375d08465b6c64cd91e7563e3917764507d779ba Signed-off-by: Arthur Heymans Reviewed-on: https://review.coreboot.org/19029 Tested-by: build bot (Jenkins) Reviewed-by: Kyösti Mälkki --- src/northbridge/amd/amdk8/f.h | 2 +- src/northbridge/amd/amdk8/pre_f.h | 2 +- src/northbridge/amd/amdk8/raminit.c | 3 +++ src/northbridge/amd/amdk8/raminit_f.c | 3 ++- 4 files changed, 7 insertions(+), 3 deletions(-) (limited to 'src/northbridge/amd') diff --git a/src/northbridge/amd/amdk8/f.h b/src/northbridge/amd/amdk8/f.h index 359a1d6283..db79fbf8d0 100644 --- a/src/northbridge/amd/amdk8/f.h +++ b/src/northbridge/amd/amdk8/f.h @@ -520,7 +520,7 @@ struct sys_info { #ifdef __PRE_RAM__ #include -struct sys_info sysinfo_car CAR_GLOBAL; +extern struct sys_info sysinfo_car; #endif #include diff --git a/src/northbridge/amd/amdk8/pre_f.h b/src/northbridge/amd/amdk8/pre_f.h index 9c1eeb685c..abc51b111f 100644 --- a/src/northbridge/amd/amdk8/pre_f.h +++ b/src/northbridge/amd/amdk8/pre_f.h @@ -264,7 +264,7 @@ struct sys_info { #ifdef __PRE_RAM__ #include -struct sys_info sysinfo_car CAR_GLOBAL; +extern struct sys_info sysinfo_car; #endif #endif /* AMDK8_PRE_F_H */ diff --git a/src/northbridge/amd/amdk8/raminit.c b/src/northbridge/amd/amdk8/raminit.c index 9f333fdaa9..48e2bb93bd 100644 --- a/src/northbridge/amd/amdk8/raminit.c +++ b/src/northbridge/amd/amdk8/raminit.c @@ -17,6 +17,9 @@ #include "option_table.h" #endif +#include +struct sys_info sysinfo_car CAR_GLOBAL; + void setup_resource_map(const unsigned int *register_values, int max) { int i; diff --git a/src/northbridge/amd/amdk8/raminit_f.c b/src/northbridge/amd/amdk8/raminit_f.c index aa2349d39b..e7a14ec454 100644 --- a/src/northbridge/amd/amdk8/raminit_f.c +++ b/src/northbridge/amd/amdk8/raminit_f.c @@ -37,10 +37,11 @@ #define printk_raminit(args...) #endif +#include +struct sys_info sysinfo_car CAR_GLOBAL; #include "f_pci.c" - /* for PCI_ADDR(0, 0x18, 2, 0x98) index, and PCI_ADDR(0x, 0x18, 2, 0x9c) data */ /* -- cgit v1.2.3