From 97be27ebbae4693a0698838edd7ccea2239ef2db Mon Sep 17 00:00:00 2001 From: Rudolf Marek Date: Mon, 13 Dec 2010 19:50:25 +0000 Subject: We hardcode highmemory size in every northbridge! This is bad, and especially if suspend to ram is involved. Let the default be taken from cbmem.h which also handles the suspend logic. Abuild tested. Please check all changes if I did not make any wrong while converting this to bytes. Signed-off-by: Rudolf Marek Acked-by: Peter Stuge git-svn-id: svn://svn.coreboot.org/coreboot/trunk@6171 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1 --- src/northbridge/amd/gx1/northbridge.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) (limited to 'src/northbridge/amd/gx1') diff --git a/src/northbridge/amd/gx1/northbridge.c b/src/northbridge/amd/gx1/northbridge.c index 9fa5e33cff..abbc85558c 100644 --- a/src/northbridge/amd/gx1/northbridge.c +++ b/src/northbridge/amd/gx1/northbridge.c @@ -67,8 +67,7 @@ static const struct pci_driver northbridge_driver __pci_driver = { }; #if CONFIG_WRITE_HIGH_TABLES==1 -#define HIGH_TABLES_SIZE 64 // maximum size of high tables in KB -extern uint64_t high_tables_base, high_tables_size; +#include #endif static void pci_domain_set_resources(device_t dev) @@ -116,8 +115,8 @@ static void pci_domain_set_resources(device_t dev) #if CONFIG_WRITE_HIGH_TABLES==1 /* Leave some space for ACPI, PIRQ and MP tables */ - high_tables_base = (tolmk - HIGH_TABLES_SIZE) * 1024; - high_tables_size = HIGH_TABLES_SIZE * 1024; + high_tables_base = (tolmk * 1024) - HIGH_MEMORY_SIZE; + high_tables_size = HIGH_MEMORY_SIZE; #endif /* Report the memory regions */ -- cgit v1.2.3