From d112f46bed85dcd6d064a057c2d355d68559f780 Mon Sep 17 00:00:00 2001 From: Timothy Pearson Date: Sat, 7 May 2016 16:05:05 -0500 Subject: nb/amd/mct_ddr3: Add support for non-ECC DIMMs on AMD Family 15h While some stubs existed before this patch to handle non-ECC memory initialization, there were a number of ECC detect unaware sections of code. Add ECC support detection to those sections. Change-Id: I56dad8a0f6833b2f42796212afb9777e9cc73d6d Tested-On: ASUS KGPE-D16 Tested-With: 1x Opteron 6262 Tested-With: 1x SuperTalent 4G non-ECC DIMM in slot A2 Signed-off-by: Timothy Pearson Reviewed-on: https://review.coreboot.org/14737 Tested-by: build bot (Jenkins) Tested-by: Raptor Engineering Automated Test Stand Reviewed-by: Damien Zammit Reviewed-by: Paul Menzel Reviewed-by: Stefan Reinauer --- src/northbridge/amd/amdmct/mct_ddr3/mct_d.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) (limited to 'src/northbridge/amd/amdmct/mct_ddr3/mct_d.c') diff --git a/src/northbridge/amd/amdmct/mct_ddr3/mct_d.c b/src/northbridge/amd/amdmct/mct_ddr3/mct_d.c index bea67b2552..1e1ef188c8 100644 --- a/src/northbridge/amd/amdmct/mct_ddr3/mct_d.c +++ b/src/northbridge/amd/amdmct/mct_ddr3/mct_d.c @@ -341,11 +341,9 @@ uint8_t is_ecc_enabled(struct MCTStatStruc *pMCTstat, struct DCTStatStruc *pDCTs if (!pMCTstat->try_ecc) ecc_enabled = 0; - if (pDCTstat->NodePresent && pDCTstat->DIMMValid) { - if (!(pDCTstat->Status & (1 << SB_ECCDIMMs))) { + if (pDCTstat->NodePresent && (pDCTstat->DIMMValidDCT[0] || pDCTstat->DIMMValidDCT[1])) + if (!(pDCTstat->Status & (1 << SB_ECCDIMMs))) ecc_enabled = 0; - } - } return !!ecc_enabled; } -- cgit v1.2.3