From 111926a1664769ab7596f2027ac041c56b5bae35 Mon Sep 17 00:00:00 2001 From: Kyösti Mälkki Date: Tue, 18 Jul 2017 00:57:37 +0300 Subject: AGESA: Cleanup ACPI S3 support MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Due to low-memory corruptions S3 support has now been (at least temporarily) removed from AGESA platfroms. Should we bring it back one day, CAR teardown on S3 path will happen with an empty stack so ugly backup/recovery of the stack will no longer be used. If S3 feature is brought back, resume path code for FCH will also see partial rewrite and agesawrapper.c file will not be part of that. Change-Id: Ib38c04d0e74f600e0b719940d5e2530f4c726cfd Signed-off-by: Kyösti Mälkki Reviewed-on: https://review.coreboot.org/20899 Tested-by: build bot (Jenkins) Reviewed-by: Paul Menzel Reviewed-by: Martin Roth --- src/northbridge/amd/agesa/family15tn/state_machine.c | 5 ----- 1 file changed, 5 deletions(-) (limited to 'src/northbridge/amd/agesa/family15tn/state_machine.c') diff --git a/src/northbridge/amd/agesa/family15tn/state_machine.c b/src/northbridge/amd/agesa/family15tn/state_machine.c index ad5a14ca98..8457d832d7 100644 --- a/src/northbridge/amd/agesa/family15tn/state_machine.c +++ b/src/northbridge/amd/agesa/family15tn/state_machine.c @@ -63,8 +63,6 @@ void platform_BeforeS3LateRestore(struct sysinfo *cb, AMD_S3LATE_PARAMS *S3Late) void platform_AfterS3LateRestore(struct sysinfo *cb, AMD_S3LATE_PARAMS *S3Late) { amd_initcpuio(); - - fchs3earlyrestore(); } void platform_BeforeInitMid(struct sysinfo *cb, AMD_MID_PARAMS *Mid) @@ -74,9 +72,6 @@ void platform_BeforeInitMid(struct sysinfo *cb, AMD_MID_PARAMS *Mid) void platform_AfterInitLate(struct sysinfo *cb, AMD_LATE_PARAMS *Late) { - /* FIXME: not reached S3 path */ - if (cb->s3resume) - fchs3laterestore(); } void platform_AfterS3Save(struct sysinfo *cb, AMD_S3SAVE_PARAMS *S3Save) -- cgit v1.2.3