From fb9458555413c6595dc67fe0f0d4f024570448e1 Mon Sep 17 00:00:00 2001 From: Kyösti Mälkki Date: Fri, 18 Aug 2017 18:20:39 +0300 Subject: sb/amd/amd8111: Define ACPI sleep states MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Note that against the specs, these definitions repeat the sleep type also in the reserved fields 3 and 4. For consistency, don't fix it here now. Entry for \_S3 is now masked off if HAVE_ACPI_RESUME=n. Change-Id: Icdc4c81d07fe7a99d5b0f8fa23e9443f58a40ab9 Signed-off-by: Kyösti Mälkki Reviewed-on: https://review.coreboot.org/21143 Tested-by: build bot (Jenkins) Reviewed-by: Marc Jones --- src/mainboard/amd/serengeti_cheetah/dsdt.asl | 4 ---- src/mainboard/amd/serengeti_cheetah_fam10/dsdt.asl | 4 ---- src/mainboard/hp/dl145_g1/dsdt.asl | 22 +--------------------- src/mainboard/iwill/dk8_htx/dsdt.asl | 5 ----- 4 files changed, 1 insertion(+), 34 deletions(-) (limited to 'src/mainboard') diff --git a/src/mainboard/amd/serengeti_cheetah/dsdt.asl b/src/mainboard/amd/serengeti_cheetah/dsdt.asl index e9f1f471b9..7e119af5dd 100644 --- a/src/mainboard/amd/serengeti_cheetah/dsdt.asl +++ b/src/mainboard/amd/serengeti_cheetah/dsdt.asl @@ -26,10 +26,6 @@ DefinitionBlock ("DSDT.aml", "DSDT", 1, "AMD-K8", "AMDACPI", 100925440) Method (FWSO, 0, NotSerialized) { } - Name (_S0, Package (0x04) { 0x00, 0x00, 0x00, 0x00 }) - Name (_S1, Package (0x04) { 0x01, 0x01, 0x01, 0x01 }) - Name (_S3, Package (0x04) { 0x05, 0x05, 0x05, 0x05 }) - Name (_S5, Package (0x04) { 0x07, 0x07, 0x07, 0x07 }) Scope (_SB) { diff --git a/src/mainboard/amd/serengeti_cheetah_fam10/dsdt.asl b/src/mainboard/amd/serengeti_cheetah_fam10/dsdt.asl index affd5b6cce..9a49ab4361 100644 --- a/src/mainboard/amd/serengeti_cheetah_fam10/dsdt.asl +++ b/src/mainboard/amd/serengeti_cheetah_fam10/dsdt.asl @@ -25,10 +25,6 @@ DefinitionBlock ("DSDT.aml", "DSDT", 1, "AMD-FAM10", "AMDACPI", 100925440) Method (FWSO, 0, NotSerialized) { } - Name (_S0, Package (0x04) { 0x00, 0x00, 0x00, 0x00 }) - Name (_S1, Package (0x04) { 0x01, 0x01, 0x01, 0x01 }) - Name (_S3, Package (0x04) { 0x05, 0x05, 0x05, 0x05 }) - Name (_S5, Package (0x04) { 0x07, 0x07, 0x07, 0x07 }) Scope (_SB) { diff --git a/src/mainboard/hp/dl145_g1/dsdt.asl b/src/mainboard/hp/dl145_g1/dsdt.asl index 8d97c897c9..5227c3a8cf 100644 --- a/src/mainboard/hp/dl145_g1/dsdt.asl +++ b/src/mainboard/hp/dl145_g1/dsdt.asl @@ -203,27 +203,7 @@ DefinitionBlock ("DSDT.aml", "DSDT", 1, "LXBIOS", "LXB-DSDT", 1) // Optional //} - // System \_Sx states - // Four bytes must be stored for each supported power state: - // 0:7 Value for PM1a_CNT.SLP_TYP register to enter this system state. - // 8:f Value for PM1b_CNT.SLP_TYP register to enter this system state. - // To enter any given state, OSPM must write the PM1a_CNT.SLP_TYP - // register before the PM1b_CNT.SLP_TYP register. - // 10:1f Reserved - // The states are: - // S0 : Working - // S1 : Sleeping with Processor Context maintained - // S2 : Sleeping with Processor Context not maintained - // S3 : Same as S2, but more power saving (e.g. suspend to RAM) - // S4 : DRAM context not maintained (e.g. suspend to disk) - // S5 : Soft Off - // If only S0 and S5 are declared then no wake-up methods are needed - Name (\_S0, Package () { 0x00, 0x00, 0x00, 0x00 }) - // S1 support should work, but never wakes up, so it's commented out - //Name (\_S1, Package () { 0x01, 0x01, 0x01, 0x01 }) - //Name (\_S3, Package () { 0x05, 0x05, 0x05, 0x05 }) - Name (\_S5, Package () { 0x07, 0x07, 0x07, 0x07 }) - //Name (\_S5, Package () { 0x02, 0x02, 0x00, 0x00 }) + #include Method (WAK, 1, NotSerialized) {} diff --git a/src/mainboard/iwill/dk8_htx/dsdt.asl b/src/mainboard/iwill/dk8_htx/dsdt.asl index 9a2f570109..e1e6341a72 100644 --- a/src/mainboard/iwill/dk8_htx/dsdt.asl +++ b/src/mainboard/iwill/dk8_htx/dsdt.asl @@ -14,11 +14,6 @@ DefinitionBlock ("DSDT.aml", "DSDT", 1, "AMD-K8", "AMDACPI", 100925440) Method (FWSO, 0, NotSerialized) { } - Name (_S0, Package (0x04) { 0x00, 0x00, 0x00, 0x00 }) - Name (_S1, Package (0x04) { 0x01, 0x01, 0x01, 0x01 }) - Name (_S3, Package (0x04) { 0x05, 0x05, 0x05, 0x05 }) - Name (_S5, Package (0x04) { 0x07, 0x07, 0x07, 0x07 }) - Scope (_SB) { Device (PCI0) -- cgit v1.2.3