From e9eb4d5df93d9a1b4ced302160b76d252c78ca6a Mon Sep 17 00:00:00 2001 From: Karthikeyan Ramasubramanian Date: Wed, 25 Mar 2020 17:37:34 -0600 Subject: mb/google/dedede: Add weak pull-up for EC_AP_PWR_BTN_ODL gpio According to the EDS, EC_AP_PWR_BTN_ODL has a default internal pull-up of 20K. Retain it during the GPIO pad configuration. BUG=b:150985246 TEST=Boot the mainboard. Change-Id: I042ba70f78fca1a5b9eda30029df97b3f8e65656 Signed-off-by: Karthikeyan Ramasubramanian Reviewed-on: https://review.coreboot.org/c/coreboot/+/39852 Reviewed-by: Justin TerAvest Reviewed-by: Furquan Shaikh Tested-by: build bot (Jenkins) --- src/mainboard/google/dedede/variants/baseboard/gpio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/mainboard') diff --git a/src/mainboard/google/dedede/variants/baseboard/gpio.c b/src/mainboard/google/dedede/variants/baseboard/gpio.c index a0127370c3..89683bd754 100644 --- a/src/mainboard/google/dedede/variants/baseboard/gpio.c +++ b/src/mainboard/google/dedede/variants/baseboard/gpio.c @@ -372,7 +372,7 @@ static const struct pad_config gpio_table[] = { /* GPD2 : EC_AP_WAKE_ODL */ PAD_CFG_NF(GPD2, NONE, DEEP, NF1), /* GPD3 : EC_AP_PWR_BTN_ODL */ - PAD_CFG_NF(GPD3, NONE, DEEP, NF1), + PAD_CFG_NF(GPD3, UP_20K, DEEP, NF1), /* GPD4 : AP_SLP_S3_L */ PAD_CFG_NF(GPD4, NONE, DEEP, NF1), /* GPD5 : AP_SLP_S4_L */ -- cgit v1.2.3