From dbac2b59128193b5c44b3587c75f09a560a2c426 Mon Sep 17 00:00:00 2001 From: Furquan Shaikh Date: Mon, 13 Jul 2020 22:36:51 -0700 Subject: soc/amd/picasso: Move PMOD global variable to globalnvs.asl Global variable `PMOD` that stores the interrupt mode used by OS is required by all mainboards. This change moves the variable definition to globalnvs.asl under picasso. Additionally, ACPI spec says that BIOS should assume interrupt mode as PIC until _PIC() method is called by OS. Thus, this change also updates the default value of PMOD as 0 i.e. PIC mode. BUG=b:153879530 Signed-off-by: Furquan Shaikh Change-Id: I731c03d965882281a7a23f55894451210ba72274 Reviewed-on: https://review.coreboot.org/c/coreboot/+/43514 Reviewed-by: Raul Rangel Reviewed-by: Aaron Durbin Tested-by: build bot (Jenkins) --- src/mainboard/amd/mandolin/acpi/mainboard.asl | 1 - .../google/zork/variants/baseboard/include/baseboard/acpi/mainboard.asl | 1 - 2 files changed, 2 deletions(-) (limited to 'src/mainboard') diff --git a/src/mainboard/amd/mandolin/acpi/mainboard.asl b/src/mainboard/amd/mandolin/acpi/mainboard.asl index d59240bc16..534155ebf1 100644 --- a/src/mainboard/amd/mandolin/acpi/mainboard.asl +++ b/src/mainboard/amd/mandolin/acpi/mainboard.asl @@ -12,4 +12,3 @@ Name(HPBA, 0xFED00000) /* Base address of HPET table */ /* Some global data */ Name(OSVR, 3) /* Assume nothing. WinXp = 1, Vista = 2, Linux = 3, WinCE = 4 */ Name(OSV, Ones) /* Assume nothing */ -Name(PMOD, One) /* Assume APIC */ diff --git a/src/mainboard/google/zork/variants/baseboard/include/baseboard/acpi/mainboard.asl b/src/mainboard/google/zork/variants/baseboard/include/baseboard/acpi/mainboard.asl index b3d39969f1..e77897033d 100644 --- a/src/mainboard/google/zork/variants/baseboard/include/baseboard/acpi/mainboard.asl +++ b/src/mainboard/google/zork/variants/baseboard/include/baseboard/acpi/mainboard.asl @@ -12,4 +12,3 @@ Name(HPBA, 0xFED00000) /* Base address of HPET table */ /* Some global data */ Name(OSVR, 3) /* Assume nothing. WinXp = 1, Vista = 2, Linux = 3, WinCE = 4 */ Name(OSV, Ones) /* Assume nothing */ -Name(PMOD, One) /* Assume APIC */ -- cgit v1.2.3