From d6ace2457ec1203d52bb7b294fda397ec1399605 Mon Sep 17 00:00:00 2001 From: Felix Held Date: Thu, 15 Apr 2021 00:07:38 +0200 Subject: mb/google/zork/smihandler: only print warning in mainboard_smi_gpi zork doesn't configure any GPIO as PAD_SMI. Since mainboard_smi_gpi will only get called for a GEVENT that will cause a non-SCI SMI, this isn't expected to be called. For the unexpected and very unlikely case that it still does get called, put a printk into mainboard_smi_gpi to see what is happening there. TEST=none Signed-off-by: Felix Held Change-Id: I14c67b21a83b334558cdd54ebf700924aa9d0808 Reviewed-on: https://review.coreboot.org/c/coreboot/+/52359 Reviewed-by: Angel Pons Reviewed-by: Marshall Dawson Tested-by: build bot (Jenkins) --- src/mainboard/google/zork/smihandler.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) (limited to 'src/mainboard') diff --git a/src/mainboard/google/zork/smihandler.c b/src/mainboard/google/zork/smihandler.c index 802487b973..3a10dd25f5 100644 --- a/src/mainboard/google/zork/smihandler.c +++ b/src/mainboard/google/zork/smihandler.c @@ -2,6 +2,7 @@ #include #include +#include #include #include #include @@ -11,9 +12,10 @@ void mainboard_smi_gpi(u32 gpi_sts) { - if (CONFIG(EC_GOOGLE_CHROMEEC)) - chromeec_smi_process_events(); + printk(BIOS_WARNING, "No GPIO is set up as PAD_SMI, so %s should never end up being " + "called. gpi_status is %x.\n", __func__, gpi_sts); } + void mainboard_smi_sleep(u8 slp_typ) { size_t num_gpios; -- cgit v1.2.3