From d0d0705f20229ac5762bc2dbcb4ae2cd2dfaee62 Mon Sep 17 00:00:00 2001 From: Mathew King Date: Wed, 9 Dec 2020 06:39:49 -0700 Subject: mb/google/zork: Remove unsused code Remove unused code that appears to be left over from grunt. Signed-off-by: Mathew King Change-Id: Id5bdb1c957342d55c5e6378c503b8d90da050601 Reviewed-on: https://review.coreboot.org/c/coreboot/+/48505 Reviewed-by: Furquan Shaikh Tested-by: build bot (Jenkins) --- src/mainboard/google/zork/mainboard.c | 13 ------------- .../google/zork/variants/baseboard/gpio_baseboard_dalboz.c | 12 ------------ .../zork/variants/baseboard/gpio_baseboard_trembyle.c | 12 ------------ .../zork/variants/baseboard/include/baseboard/variants.h | 1 - 4 files changed, 38 deletions(-) (limited to 'src/mainboard') diff --git a/src/mainboard/google/zork/mainboard.c b/src/mainboard/google/zork/mainboard.c index 5ab90cf768..dce2eafe4e 100644 --- a/src/mainboard/google/zork/mainboard.c +++ b/src/mainboard/google/zork/mainboard.c @@ -150,8 +150,6 @@ static void mainboard_devtree_update(void) static void mainboard_init(void *chip_info) { - const struct sci_source *gpes; - size_t num; int boardid; mainboard_ec_init(); @@ -162,17 +160,6 @@ static void mainboard_init(void *chip_info) /* Update DUT configuration */ mainboard_devtree_update(); - - /* - * Some platforms use SCI not generated by a GPIO pin (event above 23). - * For these boards, gpe_configure_sci() is still needed, but all GPIO - * generated events (23-0) must be removed from gpe_table[]. - * For boards that only have GPIO generated events, table gpe_table[] - * must be removed, and get_gpe_table() should return NULL. - */ - gpes = variant_gpe_table(&num); - if (gpes != NULL) - gpe_configure_sci(gpes, num); } void mainboard_get_dxio_ddi_descriptors(const fsp_dxio_descriptor **dxio_descs, diff --git a/src/mainboard/google/zork/variants/baseboard/gpio_baseboard_dalboz.c b/src/mainboard/google/zork/variants/baseboard/gpio_baseboard_dalboz.c index bf27abf953..12d2890ce2 100644 --- a/src/mainboard/google/zork/variants/baseboard/gpio_baseboard_dalboz.c +++ b/src/mainboard/google/zork/variants/baseboard/gpio_baseboard_dalboz.c @@ -169,18 +169,6 @@ struct soc_amd_gpio *variant_base_gpio_table(size_t *size) return gpio_set_stage_ram; } -/* - * This function is still needed for boards that sets gevents above 23 - * that will generate SCI or SMI. Normally this function - * points to a table of gevents and what needs to be set. The code that - * calls it was modified so that when this function returns NULL then the - * caller does nothing. - */ -const __weak struct sci_source *variant_gpe_table(size_t *num) -{ - return NULL; -} - static void wifi_power_reset_configure_active_low_power(void) { /* diff --git a/src/mainboard/google/zork/variants/baseboard/gpio_baseboard_trembyle.c b/src/mainboard/google/zork/variants/baseboard/gpio_baseboard_trembyle.c index 0745edae20..a2ad51755f 100644 --- a/src/mainboard/google/zork/variants/baseboard/gpio_baseboard_trembyle.c +++ b/src/mainboard/google/zork/variants/baseboard/gpio_baseboard_trembyle.c @@ -181,18 +181,6 @@ struct soc_amd_gpio *variant_base_gpio_table(size_t *size) return gpio_set_stage_ram; } -/* - * This function is still needed for boards that sets gevents above 23 - * that will generate SCI or SMI. Normally this function - * points to a table of gevents and what needs to be set. The code that - * calls it was modified so that when this function returns NULL then the - * caller does nothing. - */ -const __weak struct sci_source *variant_gpe_table(size_t *num) -{ - return NULL; -} - static void wifi_power_reset_configure_active_low_power(void) { /* diff --git a/src/mainboard/google/zork/variants/baseboard/include/baseboard/variants.h b/src/mainboard/google/zork/variants/baseboard/include/baseboard/variants.h index 4ec6addfe7..f6e7e7c232 100644 --- a/src/mainboard/google/zork/variants/baseboard/include/baseboard/variants.h +++ b/src/mainboard/google/zork/variants/baseboard/include/baseboard/variants.h @@ -9,7 +9,6 @@ #include #include "chip.h" -const struct sci_source *variant_gpe_table(size_t *num); const struct soc_amd_gpio *variant_early_gpio_table(size_t *size); /* * This function provides base GPIO configuration table. It is typically provided by -- cgit v1.2.3