From ccceb2250eeb820fccfb62d1f3ab407582d2e79f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Michael=20Niew=C3=B6hner?= Date: Sat, 12 Dec 2020 01:51:41 +0100 Subject: mb/clevo/kbl-u: drop duplicated configuration of UART pads MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit UART pads already get configured in bootblock by the UART driver in soc code. Thus, drop the duplicated code from the mainboard. Change-Id: I95565a74e19d693a7d5ead81e72592cc4ca2038c Signed-off-by: Michael Niewöhner Reviewed-on: https://review.coreboot.org/c/coreboot/+/48594 Tested-by: build bot (Jenkins) Reviewed-by: Felix Singer --- src/mainboard/clevo/kbl-u/Makefile.inc | 3 --- src/mainboard/clevo/kbl-u/bootblock.c | 9 --------- src/mainboard/clevo/kbl-u/include/variant/gpio.h | 1 - src/mainboard/clevo/kbl-u/variants/n13xwu/gpio_early.c | 17 ----------------- 4 files changed, 30 deletions(-) delete mode 100644 src/mainboard/clevo/kbl-u/bootblock.c delete mode 100644 src/mainboard/clevo/kbl-u/variants/n13xwu/gpio_early.c (limited to 'src/mainboard') diff --git a/src/mainboard/clevo/kbl-u/Makefile.inc b/src/mainboard/clevo/kbl-u/Makefile.inc index b424d4da19..aeb584438b 100644 --- a/src/mainboard/clevo/kbl-u/Makefile.inc +++ b/src/mainboard/clevo/kbl-u/Makefile.inc @@ -2,9 +2,6 @@ CPPFLAGS_common += -I$(src)/mainboard/$(MAINBOARDDIR)/include -bootblock-y += bootblock.c -bootblock-y += variants/$(VARIANT_DIR)/gpio_early.c - ramstage-y += ramstage.c ramstage-y += variants/$(VARIANT_DIR)/hda_verb.c ramstage-y += variants/$(VARIANT_DIR)/gpio.c diff --git a/src/mainboard/clevo/kbl-u/bootblock.c b/src/mainboard/clevo/kbl-u/bootblock.c deleted file mode 100644 index b351fbd8ef..0000000000 --- a/src/mainboard/clevo/kbl-u/bootblock.c +++ /dev/null @@ -1,9 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ - -#include -#include - -void bootblock_mainboard_early_init(void) -{ - variant_configure_early_gpios(); -} diff --git a/src/mainboard/clevo/kbl-u/include/variant/gpio.h b/src/mainboard/clevo/kbl-u/include/variant/gpio.h index 95d576294f..4258325cf9 100644 --- a/src/mainboard/clevo/kbl-u/include/variant/gpio.h +++ b/src/mainboard/clevo/kbl-u/include/variant/gpio.h @@ -3,7 +3,6 @@ #ifndef VARIANT_GPIO_H #define VARIANT_GPIO_H -void variant_configure_early_gpios(void); void variant_configure_gpios(void); #endif diff --git a/src/mainboard/clevo/kbl-u/variants/n13xwu/gpio_early.c b/src/mainboard/clevo/kbl-u/variants/n13xwu/gpio_early.c deleted file mode 100644 index dc55aae6d3..0000000000 --- a/src/mainboard/clevo/kbl-u/variants/n13xwu/gpio_early.c +++ /dev/null @@ -1,17 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ - -#include -#include - -static const struct pad_config early_gpio_table[] = { - // UART2_RXD - _PAD_CFG_STRUCT(GPP_C20, 0x44000702, 0x0), - - // UART2_TXD - _PAD_CFG_STRUCT(GPP_C21, 0x44000700, 0x0) -}; - -void variant_configure_early_gpios(void) -{ - gpio_configure_pads(early_gpio_table, ARRAY_SIZE(early_gpio_table)); -} -- cgit v1.2.3