From c859f10eec6b8f8120c4683f281461a68f9b374f Mon Sep 17 00:00:00 2001 From: Kyösti Mälkki Date: Tue, 1 Jan 2019 08:58:59 +0200 Subject: intel/e7505: Drop ECC scrubber code MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This was already disabled and mostly incompatible with romstage having stack in CAR. Change-Id: I1fe02bef668a5bc8ce3d5a1d8090670752b10c3e Signed-off-by: Kyösti Mälkki Reviewed-on: https://review.coreboot.org/c/30621 Tested-by: build bot (Jenkins) Reviewed-by: Arthur Heymans --- src/mainboard/aopen/dxplplusu/Kconfig | 1 - src/mainboard/aopen/dxplplusu/romstage.c | 12 ------------ 2 files changed, 13 deletions(-) (limited to 'src/mainboard') diff --git a/src/mainboard/aopen/dxplplusu/Kconfig b/src/mainboard/aopen/dxplplusu/Kconfig index 8e3178529e..85c45d51f3 100644 --- a/src/mainboard/aopen/dxplplusu/Kconfig +++ b/src/mainboard/aopen/dxplplusu/Kconfig @@ -12,7 +12,6 @@ config BOARD_SPECIFIC_OPTIONS select UDELAY_TSC select HAVE_ACPI_TABLES select BOARD_ROMSIZE_KB_2048 -# select HW_SCRUBBER config MAINBOARD_DIR string diff --git a/src/mainboard/aopen/dxplplusu/romstage.c b/src/mainboard/aopen/dxplplusu/romstage.c index 73a9ce07e3..75aad28093 100644 --- a/src/mainboard/aopen/dxplplusu/romstage.c +++ b/src/mainboard/aopen/dxplplusu/romstage.c @@ -66,18 +66,6 @@ void mainboard_romstage_entry(unsigned long bist) /* The real MCH initialisation. */ e7505_mch_init(memctrl); - /* - * ECC scrub invalidates cache, so all stack in CAR - * is lost. Only return addresses from main() and - * scrub_ecc() are recovered to stack via xmm0-xmm3. - */ -#if IS_ENABLED(CONFIG_HW_SCRUBBER) -#if !IS_ENABLED(CONFIG_USBDEBUG_IN_ROMSTAGE) - unsigned long ret_addr = (unsigned long)((unsigned long*)&bist - 1); - e7505_mch_scrub_ecc(ret_addr); -#endif -#endif - /* Hook for post ECC scrub settings and debug. */ e7505_mch_done(memctrl); -- cgit v1.2.3