From bfb171d6d954b7235f93da7ce8a35274e914cb40 Mon Sep 17 00:00:00 2001 From: Roger Wang Date: Sat, 5 Oct 2024 11:28:12 +0800 Subject: mb/google/nissa/var/sundance: Change touch panel and wwan gpio setting In order to fit the specification, change gpio setting for touch panel and wwan. Change items: 1. wwan : Add WWAN_RST_L to 0. And we want WWAN_EN to pull high more early than WWAN_RST_L, so add WWAN_EN to 1 in romstage stage. 2. touch panel : First we add EN_PP3300_TCHSCR and USI_RST_L to 0 to init status. And we want EN_PP3300_TCHSCR to pull high more early than USI_RST_L so delete USI_RST_L pull high in romstage. BUG=b:357764679 Test=emerge-nissa coreboot Change-Id: I0a07ea8e2bf3d165dcebd89c4c564f157d9d4846 Signed-off-by: Roger Wang Reviewed-on: https://review.coreboot.org/c/coreboot/+/84668 Reviewed-by: Eric Lai Tested-by: build bot (Jenkins) --- src/mainboard/google/brya/variants/sundance/gpio.c | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) (limited to 'src/mainboard') diff --git a/src/mainboard/google/brya/variants/sundance/gpio.c b/src/mainboard/google/brya/variants/sundance/gpio.c index f4714b4dfd..8016d5d8d9 100644 --- a/src/mainboard/google/brya/variants/sundance/gpio.c +++ b/src/mainboard/google/brya/variants/sundance/gpio.c @@ -16,8 +16,6 @@ static const struct pad_config override_gpio_table[] = { PAD_NC_LOCK(GPP_B5, NONE, LOCK_CONFIG), /* B6 : NC */ PAD_NC_LOCK(GPP_B6, NONE, LOCK_CONFIG), - /* C1 : SMBDATA ==> USI_RST_L */ - PAD_CFG_GPO(GPP_C1, 1, DEEP), /* D3 : WCAM_RST_L ==> NC */ PAD_NC_LOCK(GPP_D3, NONE, LOCK_CONFIG), /* D6 : SRCCLKREQ1# ==> WWAN_EN */ @@ -35,7 +33,7 @@ static const struct pad_config override_gpio_table[] = { /* E21 : NC */ PAD_NC_LOCK(GPP_E21, NONE, LOCK_CONFIG), /* F12 : WWAN_RST_L */ - PAD_CFG_GPO_LOCK(GPP_F12, 1, LOCK_CONFIG), + PAD_CFG_GPO(GPP_F12, 1, DEEP), /* F13 : NC */ PAD_NC_LOCK(GPP_F13, NONE, LOCK_CONFIG), /* F15 : NC */ @@ -64,6 +62,13 @@ static const struct pad_config early_gpio_table[] = { */ /* D6 : SRCCLKREQ1# ==> WWAN_EN */ PAD_CFG_GPO(GPP_D6, 0, DEEP), + /* F12 : WWAN_RST_L */ + PAD_CFG_GPO(GPP_F12, 0, DEEP), + /* Enable touchscreen, hold in reset */ + /* C0 : SMBCLK ==> EN_PP3300_TCHSCR */ + PAD_CFG_GPO(GPP_C0, 0, DEEP), + /* C1 : SMBDATA ==> USI_RST_L */ + PAD_CFG_GPO(GPP_C1, 0, DEEP), /* E12 : THC0_SPI1_IO1 ==> SOC_WP_OD */ PAD_CFG_GPI_GPIO_DRIVER(GPP_E12, NONE, DEEP), /* F18 : THC1_SPI2_INT# ==> EC_IN_RW_OD */ @@ -80,11 +85,11 @@ static const struct pad_config early_gpio_table[] = { /* Pad configuration in romstage for Sundance */ static const struct pad_config romstage_gpio_table[] = { + /* D6 : SRCCLKREQ1# ==> WWAN_EN */ + PAD_CFG_GPO(GPP_D6, 1, DEEP), /* Enable touchscreen, hold in reset */ /* C0 : SMBCLK ==> EN_PP3300_TCHSCR */ PAD_CFG_GPO(GPP_C0, 1, DEEP), - /* C1 : SMBDATA ==> USI_RST_L */ - PAD_CFG_GPO(GPP_C1, 1, DEEP), }; const struct pad_config *variant_gpio_override_table(size_t *num) -- cgit v1.2.3