From b80de180c2ebd7bde5ce4da43d5e0f0c260c25e7 Mon Sep 17 00:00:00 2001 From: Arthur Heymans Date: Mon, 16 May 2022 15:29:53 +0200 Subject: vendorcode/amd/agesa/fam16kb: Fix improper use of .data AGESA has a lot of code in the .data section which is for initialized data, that in fact should be .rodata. This adds the 'CONST' keyword everywhere it is needed. TEST: See in the .elf file (e.g. using readelf) that there is nothing in .data section. Change-Id: Ie8817434ee0bc6c195eabe090f195512c0043ae5 Signed-off-by: Arthur Heymans Reviewed-on: https://review.coreboot.org/c/coreboot/+/64400 Tested-by: build bot (Jenkins) Reviewed-by: Angel Pons Reviewed-by: Stefan Reinauer --- src/mainboard/hp/abm/buildOpts.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/mainboard') diff --git a/src/mainboard/hp/abm/buildOpts.c b/src/mainboard/hp/abm/buildOpts.c index 2d1128644b..fd4323acba 100644 --- a/src/mainboard/hp/abm/buildOpts.c +++ b/src/mainboard/hp/abm/buildOpts.c @@ -43,7 +43,7 @@ #include "cpuLateInit.h" #include "GnbInterface.h" -GPIO_CONTROL hp_abm_gpio[] = { +CONST GPIO_CONTROL hp_abm_gpio[] = { { 45, Function2, GpioOutEnB | Sticky }, // Signal input APU_SD_LED { 49, Function2, PullUpB | PullDown | Sticky }, // Signal output APU_ABM_LED_UID { 50, Function2, PullUpB | PullDown | Sticky }, // Signal output APU_ABM_LED_HEALTH -- cgit v1.2.3