From aef345bfd7344aaab167f7dda3f49f9db80d7f9f Mon Sep 17 00:00:00 2001 From: Mark Hasemeyer Date: Wed, 29 Nov 2023 16:19:42 -0700 Subject: mb/google/{brya,brox,rex}: Update ec_sync wake capability Some of the boards use the EC_SYNC pin to wake the AP but do not advertise the pin as wake capable in the CREC _CRS resource. Relevant boards were determined through empirical testing and inspection of gpio configuration. Update the ACPI tables for rex, brya, and brox based boards to advertise their EC_SYNC pin as wake capable. BUG=b:243700486 TEST=-Dump ACPI and verify ExclusiveAndWake share type is set when EC_SYNC_IRQ_WAKE_CAPABLE is defined -Wake Aviko via keypress and verify chromeos-ec as wake source -Wake Screebo via lid open and verify chromeos-ec as wake source Change-Id: I5828be7c9420cab6ae838272c8301c302a3e078c Signed-off-by: Mark Hasemeyer Reviewed-on: https://review.coreboot.org/c/coreboot/+/79374 Reviewed-by: Eric Lai Reviewed-by: Nick Vaccaro Reviewed-by: Kapil Porwal Tested-by: build bot (Jenkins) Reviewed-by: Subrata Banik --- src/mainboard/google/brox/variants/baseboard/brox/include/baseboard/ec.h | 1 + .../google/brya/variants/baseboard/brask/include/baseboard/ec.h | 1 + src/mainboard/google/brya/variants/baseboard/brya/include/baseboard/ec.h | 1 + .../google/brya/variants/baseboard/hades/include/baseboard/ec.h | 1 + src/mainboard/google/rex/variants/baseboard/ovis/include/baseboard/ec.h | 1 + src/mainboard/google/rex/variants/baseboard/rex/include/baseboard/ec.h | 1 + 6 files changed, 6 insertions(+) (limited to 'src/mainboard') diff --git a/src/mainboard/google/brox/variants/baseboard/brox/include/baseboard/ec.h b/src/mainboard/google/brox/variants/baseboard/brox/include/baseboard/ec.h index 722f48bb32..a027b4c9f6 100644 --- a/src/mainboard/google/brox/variants/baseboard/brox/include/baseboard/ec.h +++ b/src/mainboard/google/brox/variants/baseboard/brox/include/baseboard/ec.h @@ -75,5 +75,6 @@ #define SIO_EC_ENABLE_PS2K /* Enable PS/2 Keyboard */ #define EC_ENABLE_SYNC_IRQ /* Enable tight timestamp / wake support */ +#define EC_SYNC_IRQ_WAKE_CAPABLE /* Let the OS know ec_sync is wake capable */ #endif /* __BASEBOARD_EC_H__ */ diff --git a/src/mainboard/google/brya/variants/baseboard/brask/include/baseboard/ec.h b/src/mainboard/google/brya/variants/baseboard/brask/include/baseboard/ec.h index caca0f3190..48cec0c091 100644 --- a/src/mainboard/google/brya/variants/baseboard/brask/include/baseboard/ec.h +++ b/src/mainboard/google/brya/variants/baseboard/brask/include/baseboard/ec.h @@ -41,5 +41,6 @@ #define SIO_EC_HOST_ENABLE /* EC Host Interface Resources */ #define EC_ENABLE_SYNC_IRQ /* Enable tight timestamp / wake support */ +#define EC_SYNC_IRQ_WAKE_CAPABLE /* Let the OS know ec_sync is wake capable */ #endif /* __BASEBOARD_EC_H__ */ diff --git a/src/mainboard/google/brya/variants/baseboard/brya/include/baseboard/ec.h b/src/mainboard/google/brya/variants/baseboard/brya/include/baseboard/ec.h index 8ca2dbd386..8d296ac574 100644 --- a/src/mainboard/google/brya/variants/baseboard/brya/include/baseboard/ec.h +++ b/src/mainboard/google/brya/variants/baseboard/brya/include/baseboard/ec.h @@ -80,5 +80,6 @@ #define SIO_EC_ENABLE_PS2K /* Enable PS/2 Keyboard */ #define EC_ENABLE_SYNC_IRQ /* Enable tight timestamp / wake support */ +#define EC_SYNC_IRQ_WAKE_CAPABLE /* Let the OS know ec_sync is wake capable */ #endif /* __BASEBOARD_EC_H__ */ diff --git a/src/mainboard/google/brya/variants/baseboard/hades/include/baseboard/ec.h b/src/mainboard/google/brya/variants/baseboard/hades/include/baseboard/ec.h index 122cc0cbe8..545eb97329 100644 --- a/src/mainboard/google/brya/variants/baseboard/hades/include/baseboard/ec.h +++ b/src/mainboard/google/brya/variants/baseboard/hades/include/baseboard/ec.h @@ -70,5 +70,6 @@ #define SIO_EC_ENABLE_PS2K /* Enable PS/2 Keyboard */ #define EC_ENABLE_SYNC_IRQ /* Enable tight timestamp / wake support */ +#define EC_SYNC_IRQ_WAKE_CAPABLE /* Let the OS know ec_sync is wake capable */ #endif /* __BASEBOARD_EC_H__ */ diff --git a/src/mainboard/google/rex/variants/baseboard/ovis/include/baseboard/ec.h b/src/mainboard/google/rex/variants/baseboard/ovis/include/baseboard/ec.h index a0f47d9360..37c8a74318 100644 --- a/src/mainboard/google/rex/variants/baseboard/ovis/include/baseboard/ec.h +++ b/src/mainboard/google/rex/variants/baseboard/ovis/include/baseboard/ec.h @@ -60,5 +60,6 @@ #define SIO_EC_ENABLE_PS2K /* Enable PS/2 Keyboard */ #define EC_ENABLE_SYNC_IRQ /* Enable tight timestamp / wake support */ +#define EC_SYNC_IRQ_WAKE_CAPABLE /* Let the OS know ec_sync is wake capable */ #endif /* __BASEBOARD_EC_H__ */ diff --git a/src/mainboard/google/rex/variants/baseboard/rex/include/baseboard/ec.h b/src/mainboard/google/rex/variants/baseboard/rex/include/baseboard/ec.h index 4dc2bcefa6..f4a9aab3ca 100644 --- a/src/mainboard/google/rex/variants/baseboard/rex/include/baseboard/ec.h +++ b/src/mainboard/google/rex/variants/baseboard/rex/include/baseboard/ec.h @@ -74,5 +74,6 @@ #define SIO_EC_ENABLE_PS2K /* Enable PS/2 Keyboard */ #define EC_ENABLE_SYNC_IRQ /* Enable tight timestamp / wake support */ +#define EC_SYNC_IRQ_WAKE_CAPABLE /* Let the OS know ec_sync is wake capable */ #endif /* __BASEBOARD_EC_H__ */ -- cgit v1.2.3