From a2c0cf5dfe4c2666cf4302c58360c45819b1f769 Mon Sep 17 00:00:00 2001 From: John Zhao Date: Mon, 20 Aug 2018 10:27:39 -0700 Subject: mb/google/octopus: Add null pointer check src/mainboard/google/octopus/mainboard.c Function dev_find_slot may return NULL, check before its usage. Found-by: klockwork BRANCH=None TEST=Built & booted Yorp board. Change-Id: I160adbe3b0a5a2b0f11fd1567513860664d4bee3 Signed-off-by: John Zhao Reviewed-on: https://review.coreboot.org/28235 Reviewed-by: Furquan Shaikh Reviewed-by: Paul Menzel Tested-by: build bot (Jenkins) --- src/mainboard/google/octopus/mainboard.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'src/mainboard') diff --git a/src/mainboard/google/octopus/mainboard.c b/src/mainboard/google/octopus/mainboard.c index 61d254ee5a..6effa7c080 100644 --- a/src/mainboard/google/octopus/mainboard.c +++ b/src/mainboard/google/octopus/mainboard.c @@ -169,7 +169,8 @@ static void wifi_device_update(void) devfn = PCH_DEVFN_PCIE1; dev = dev_find_slot(0, devfn); - dev->enabled = 0; + if (dev) + dev->enabled = 0; } void mainboard_devtree_update(struct device *dev) -- cgit v1.2.3