From 95acd31d302d6cb2c6b2be0b6c0eb9f9318d1078 Mon Sep 17 00:00:00 2001 From: Wentao Qin Date: Tue, 19 Dec 2023 17:30:55 +0800 Subject: mb/google/rex/var/screebo: Remove Camera EEPROM off timing Since the camera sensor and camera eeprom share GPP_A12, remove the off timing to avoid issue of camera sensor loss, but this will increase system power by 5mW. (Before root cause, this is a short term workaround to unblock function test.) BUG=b:298126852 TEST=1. Run coldreboot/warmreboot check see if the camera sensor lost. 2. Run S0ix check to see if the camera function abnormal. Change-Id: I49b6ecbfbf3dddd6575bdaaf9c8fd0ee6c09af25 Signed-off-by: Wentao Qin Reviewed-on: https://review.coreboot.org/c/coreboot/+/79647 Reviewed-by: Jason Z Chen Reviewed-by: Paul Menzel Reviewed-by: Subrata Banik Tested-by: build bot (Jenkins) Reviewed-by: Eric Lai Reviewed-by: Kun Liu --- src/mainboard/google/rex/variants/screebo/overridetree.cb | 4 ---- 1 file changed, 4 deletions(-) (limited to 'src/mainboard') diff --git a/src/mainboard/google/rex/variants/screebo/overridetree.cb b/src/mainboard/google/rex/variants/screebo/overridetree.cb index 3af628d787..3b62e020b2 100644 --- a/src/mainboard/google/rex/variants/screebo/overridetree.cb +++ b/src/mainboard/google/rex/variants/screebo/overridetree.cb @@ -553,10 +553,6 @@ chip soc/intel/meteorlake register "on_seq.ops_cnt" = "1" register "on_seq.ops[0]" = "SEQ_OPS_GPIO_ENABLE(0, 0)" - #_OFF - register "off_seq.ops_cnt" = "1" - register "off_seq.ops[0]" = "SEQ_OPS_GPIO_DISABLE(0, 0)" - register "nvm_size" = "0x2000" register "nvm_pagesize" = "1" register "nvm_readonly" = "1" -- cgit v1.2.3