From 65e43dd1a8aa19dac6cf2c33686e618de7d24b3b Mon Sep 17 00:00:00 2001 From: Jon Murphy Date: Tue, 22 Mar 2022 11:51:56 -0600 Subject: mb/google/skyrim: Fix Backlight GPIO Backlight GPIO was set to HIGH, when it should have been set LOW to enable the backlight in the embedded display. BUG=b:224618411 TEST=load on Skyrim proto1, observe backlight Signed-off-by: Jon Murphy Change-Id: Ife3335ca5a3c2517a6817fccf0544e5fcacb1f9d Reviewed-on: https://review.coreboot.org/c/coreboot/+/63003 Reviewed-by: Felix Held Reviewed-by: Karthik Ramasubramanian Tested-by: build bot (Jenkins) --- src/mainboard/google/skyrim/variants/baseboard/gpio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/mainboard') diff --git a/src/mainboard/google/skyrim/variants/baseboard/gpio.c b/src/mainboard/google/skyrim/variants/baseboard/gpio.c index 204ddf65a2..d586405f0c 100644 --- a/src/mainboard/google/skyrim/variants/baseboard/gpio.c +++ b/src/mainboard/google/skyrim/variants/baseboard/gpio.c @@ -61,7 +61,7 @@ static const struct soc_amd_gpio base_gpio_table[] = { /* EN_PP3300_TCHSCR */ PAD_GPO(GPIO_29, HIGH), /* SOC_DISABLE_DISP_BL */ - PAD_GPO(GPIO_30, HIGH), + PAD_GPO(GPIO_30, LOW), /* Unused */ PAD_NC(GPIO_31), /* LPC_RST_L */ -- cgit v1.2.3