From 55a8d8a772322e5ceb71c28785b1815970c468c5 Mon Sep 17 00:00:00 2001 From: Enrico Granata Date: Wed, 15 Aug 2018 17:13:47 -0700 Subject: nocturne: Enable debouncing of SX9310 CLOSE / FAR IRQs This is meant to solve an issue where the proximity sensor may fluctuate between CLOSE / FAR in rapid succession upon the user removing their hand from the unit, before settling on the correct output. Using the hardware debouncing filter solves this issue and removes the spurious fluctuations. BRANCH=None BUG=None TEST=manual on Nocturne, observing events come in Change-Id: I78cc4852d42fcda6209fedce1ce91236b5814571 Signed-off-by: Enrico Granata Reviewed-on: https://review.coreboot.org/28112 Reviewed-by: Furquan Shaikh Reviewed-by: Gwendal Grignou Reviewed-by: Paul Menzel Tested-by: build bot (Jenkins) --- src/mainboard/google/poppy/variants/nocturne/devicetree.cb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'src/mainboard') diff --git a/src/mainboard/google/poppy/variants/nocturne/devicetree.cb b/src/mainboard/google/poppy/variants/nocturne/devicetree.cb index 88af9294d5..f81d43d1f2 100644 --- a/src/mainboard/google/poppy/variants/nocturne/devicetree.cb +++ b/src/mainboard/google/poppy/variants/nocturne/devicetree.cb @@ -309,7 +309,7 @@ chip soc/intel/skylake register "reg_prox_ctrl7" = "0x0d" register "reg_prox_ctrl8" = "0x8d" register "reg_prox_ctrl9" = "0x43" - register "reg_prox_ctrl10" = "0x11" + register "reg_prox_ctrl10" = "0x1f" register "reg_prox_ctrl11" = "0x00" register "reg_prox_ctrl12" = "0x00" register "reg_prox_ctrl13" = "0x00" @@ -350,7 +350,7 @@ chip soc/intel/skylake register "reg_prox_ctrl7" = "0x0d" register "reg_prox_ctrl8" = "0x8d" register "reg_prox_ctrl9" = "0x43" - register "reg_prox_ctrl10" = "0x11" + register "reg_prox_ctrl10" = "0x1f" register "reg_prox_ctrl11" = "0x00" register "reg_prox_ctrl12" = "0x00" register "reg_prox_ctrl13" = "0x00" -- cgit v1.2.3