From 5481eb3c2e753ed89dd1eed4e2da96e03c48ef67 Mon Sep 17 00:00:00 2001 From: Felix Held Date: Fri, 6 May 2022 17:39:46 +0200 Subject: mb/google/guybrush/devicetree: use defines for ComboPhyStaticConfig Use the existing definitions from FspUsb.h instead of magic values for the ComboPhyStaticConfig settings in the mainboard's devicetree. Signed-off-by: Felix Held Change-Id: I2707d017909b7516e5d8711c8f4e2914165ed10d Reviewed-on: https://review.coreboot.org/c/coreboot/+/64124 Tested-by: build bot (Jenkins) Reviewed-by: Raul Rangel Reviewed-by: Angel Pons --- src/mainboard/google/guybrush/variants/baseboard/devicetree.cb | 4 ++-- src/mainboard/google/guybrush/variants/nipperkin/overridetree.cb | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) (limited to 'src/mainboard') diff --git a/src/mainboard/google/guybrush/variants/baseboard/devicetree.cb b/src/mainboard/google/guybrush/variants/baseboard/devicetree.cb index 696e16dbfe..0b69af9f9b 100644 --- a/src/mainboard/google/guybrush/variants/baseboard/devicetree.cb +++ b/src/mainboard/google/guybrush/variants/baseboard/devicetree.cb @@ -217,8 +217,8 @@ chip soc/amd/cezanne .tx_vboost_lvl_en=1, .tx_vboost_lvl=5, }, - .ComboPhyStaticConfig[0] = 0, - .ComboPhyStaticConfig[1] = 0, + .ComboPhyStaticConfig[0] = USB_COMBO_PHY_MODE_USB_C, + .ComboPhyStaticConfig[1] = USB_COMBO_PHY_MODE_USB_C, .BatteryChargerEnable = 0, .PhyP3CpmP4Support = 0, }" diff --git a/src/mainboard/google/guybrush/variants/nipperkin/overridetree.cb b/src/mainboard/google/guybrush/variants/nipperkin/overridetree.cb index 85581d2d5a..8270b147bb 100644 --- a/src/mainboard/google/guybrush/variants/nipperkin/overridetree.cb +++ b/src/mainboard/google/guybrush/variants/nipperkin/overridetree.cb @@ -154,8 +154,8 @@ chip soc/amd/cezanne .tx_vboost_lvl_en=1, .tx_vboost_lvl=5, }, - .ComboPhyStaticConfig[0] = 0, - .ComboPhyStaticConfig[1] = 0, + .ComboPhyStaticConfig[0] = USB_COMBO_PHY_MODE_USB_C, + .ComboPhyStaticConfig[1] = USB_COMBO_PHY_MODE_USB_C, .BatteryChargerEnable = 0, .PhyP3CpmP4Support = 0, }" -- cgit v1.2.3