From 4aad743434516d6c96f1afe21dd00b631e2c3692 Mon Sep 17 00:00:00 2001 From: Vladimir Serbinenko Date: Sat, 22 Nov 2014 20:36:58 +0100 Subject: i82801gx: Enable upper CMOS in bootblock. Otherwise checksum may not work correctly on early stages. For compatibility with old bootblocks also enable it early in romstage. Change-Id: Ie541d71bd76af182e445aa5ef21fe5ba77091159 Signed-off-by: Vladimir Serbinenko Reviewed-on: http://review.coreboot.org/7556 Tested-by: build bot (Jenkins) Reviewed-by: Patrick Georgi --- src/mainboard/apple/macbook21/romstage.c | 3 --- src/mainboard/getac/p470/romstage.c | 3 --- src/mainboard/ibase/mb899/romstage.c | 3 --- src/mainboard/intel/d945gclf/romstage.c | 3 --- src/mainboard/kontron/986lcd-m/romstage.c | 3 --- src/mainboard/lenovo/t60/romstage.c | 3 --- src/mainboard/lenovo/x60/romstage.c | 3 --- src/mainboard/roda/rk886ex/romstage.c | 3 --- 8 files changed, 24 deletions(-) (limited to 'src/mainboard') diff --git a/src/mainboard/apple/macbook21/romstage.c b/src/mainboard/apple/macbook21/romstage.c index 39a8e466b0..443fdc55af 100644 --- a/src/mainboard/apple/macbook21/romstage.c +++ b/src/mainboard/apple/macbook21/romstage.c @@ -216,9 +216,6 @@ static void rcba_config(void) /* Enable IOAPIC */ RCBA8(0x31ff) = 0x03; - /* Enable upper 128bytes of CMOS */ - RCBA32(0x3400) = (1 << 2); - /* Disable unused devices */ RCBA32(0x3418) = FD_PCIE6 | FD_PCIE5 | FD_PCIE4 | FD_PCIE3 | FD_INTLAN | FD_ACMOD | FD_ACAUD; RCBA32(0x3418) |= (1 << 0); // Required. diff --git a/src/mainboard/getac/p470/romstage.c b/src/mainboard/getac/p470/romstage.c index 7b60ae5fab..b57e6b7be4 100644 --- a/src/mainboard/getac/p470/romstage.c +++ b/src/mainboard/getac/p470/romstage.c @@ -191,9 +191,6 @@ static void rcba_config(void) /* Enable IOAPIC */ RCBA8(0x31ff) = 0x03; - /* Enable upper 128bytes of CMOS */ - RCBA32(0x3400) = (1 << 2); - /* Disable unused devices */ RCBA32(0x3418) = FD_PCIE6 | FD_PCIE5 | FD_INTLAN | FD_ACMOD | FD_ACAUD | FD_PATA; RCBA32(0x3418) |= (1 << 0); // Required. diff --git a/src/mainboard/ibase/mb899/romstage.c b/src/mainboard/ibase/mb899/romstage.c index 38e862007f..ece65d83e6 100644 --- a/src/mainboard/ibase/mb899/romstage.c +++ b/src/mainboard/ibase/mb899/romstage.c @@ -163,9 +163,6 @@ static void rcba_config(void) /* Enable IOAPIC */ RCBA8(0x31ff) = 0x03; - /* Enable upper 128bytes of CMOS */ - RCBA32(0x3400) = (1 << 2); - /* Enable PCIe Root Port Clock Gate */ // RCBA32(0x341c) = 0x00000001; } diff --git a/src/mainboard/intel/d945gclf/romstage.c b/src/mainboard/intel/d945gclf/romstage.c index 4508968c46..4194a80aaa 100644 --- a/src/mainboard/intel/d945gclf/romstage.c +++ b/src/mainboard/intel/d945gclf/romstage.c @@ -89,9 +89,6 @@ static void rcba_config(void) /* Enable IOAPIC */ RCBA8(0x31ff) = 0x03; - /* Enable upper 128bytes of CMOS */ - RCBA32(0x3400) = (1 << 2); - /* Disable unused devices */ //RCBA32(0x3418) = FD_PCIE6|FD_PCIE5|FD_PCIE4|FD_ACMOD|FD_ACAUD|FD_PATA; // RCBA32(0x3418) |= (1 << 0); // Required. diff --git a/src/mainboard/kontron/986lcd-m/romstage.c b/src/mainboard/kontron/986lcd-m/romstage.c index dc7da996e0..652d8cb7c4 100644 --- a/src/mainboard/kontron/986lcd-m/romstage.c +++ b/src/mainboard/kontron/986lcd-m/romstage.c @@ -222,9 +222,6 @@ static void rcba_config(void) /* Enable IOAPIC */ RCBA8(0x31ff) = 0x03; - /* Enable upper 128bytes of CMOS */ - RCBA32(0x3400) = (1 << 2); - /* Now, this is a bit ugly. As per PCI specification, function 0 of a * device always has to be implemented. So disabling ethernet port 1 * would essentially disable all three ethernet ports of the mainboard. diff --git a/src/mainboard/lenovo/t60/romstage.c b/src/mainboard/lenovo/t60/romstage.c index 350c2dead3..571a21cfd6 100644 --- a/src/mainboard/lenovo/t60/romstage.c +++ b/src/mainboard/lenovo/t60/romstage.c @@ -137,9 +137,6 @@ static void rcba_config(void) /* Enable IOAPIC */ RCBA8(0x31ff) = 0x03; - /* Enable upper 128bytes of CMOS */ - RCBA32(0x3400) = (1 << 2); - /* Disable unused devices */ RCBA32(0x3418) = FD_PCIE6 | FD_PCIE5 | FD_INTLAN | FD_ACMOD | FD_ACAUD; RCBA32(0x3418) |= (1 << 0); // Required. diff --git a/src/mainboard/lenovo/x60/romstage.c b/src/mainboard/lenovo/x60/romstage.c index 4596a1a2d2..af9b1be653 100644 --- a/src/mainboard/lenovo/x60/romstage.c +++ b/src/mainboard/lenovo/x60/romstage.c @@ -144,9 +144,6 @@ static void rcba_config(void) /* Enable IOAPIC */ RCBA8(0x31ff) = 0x03; - /* Enable upper 128bytes of CMOS */ - RCBA32(0x3400) = (1 << 2); - /* Disable unused devices */ RCBA32(0x3418) = FD_PCIE6 | FD_PCIE5 | FD_INTLAN | FD_ACMOD | FD_ACAUD; RCBA32(0x3418) |= (1 << 0); // Required. diff --git a/src/mainboard/roda/rk886ex/romstage.c b/src/mainboard/roda/rk886ex/romstage.c index c9ec4f152d..e8ada36d78 100644 --- a/src/mainboard/roda/rk886ex/romstage.c +++ b/src/mainboard/roda/rk886ex/romstage.c @@ -169,9 +169,6 @@ static void rcba_config(void) /* Enable IOAPIC */ RCBA8(0x31ff) = 0x03; - /* Enable upper 128bytes of CMOS */ - RCBA32(0x3400) = (1 << 2); - /* Disable unused devices */ RCBA32(0x3418) = FD_PCIE6 | FD_PCIE5 | FD_PCIE3 | FD_PCIE2 | FD_INTLAN | FD_ACMOD | FD_HDAUD | FD_PATA; -- cgit v1.2.3