From 0f864f6ef90d922fe09888a8ed500eb6be4a340c Mon Sep 17 00:00:00 2001 From: Elyes Haouas Date: Sun, 13 Nov 2022 07:34:48 +0100 Subject: mb/google: Fix log messages Change 'printk(BIOS_DEBUG, "ERROR:' to printk(BIOS_ERR, "'. Change-Id: Id31c25f5b8686f951ab4f331682b82ff327d5e78 Signed-off-by: Elyes Haouas Reviewed-on: https://review.coreboot.org/c/coreboot/+/69496 Tested-by: build bot (Jenkins) Reviewed-by: Eric Lai --- src/mainboard/google/auron/variants/buddy/variant.c | 6 ++---- src/mainboard/google/beltino/lan.c | 6 ++---- src/mainboard/google/butterfly/mainboard.c | 7 +++---- src/mainboard/google/jecht/lan.c | 6 ++---- src/mainboard/google/rambi/variants/ninja/lan.c | 6 ++---- src/mainboard/google/rambi/variants/sumo/lan.c | 6 ++---- 6 files changed, 13 insertions(+), 24 deletions(-) (limited to 'src/mainboard') diff --git a/src/mainboard/google/auron/variants/buddy/variant.c b/src/mainboard/google/auron/variants/buddy/variant.c index 397b54193a..5af2502e65 100644 --- a/src/mainboard/google/auron/variants/buddy/variant.c +++ b/src/mainboard/google/auron/variants/buddy/variant.c @@ -55,8 +55,7 @@ static unsigned char get_hex_digit(u8 *offset) retval = *offset - 'a' + 0x0a; } if (retval > 0x0F) { - printk(BIOS_DEBUG, "Error: Invalid Hex digit found: %c - 0x%02x\n", - *offset, *offset); + printk(BIOS_ERR, "Invalid Hex digit found: %c - 0x%02x\n", *offset, *offset); retval = 0; } @@ -72,8 +71,7 @@ static int get_mac_address(u32 *high_dword, u32 *low_dword, offset = search(key, search_address, sizeof(key) - 1, search_length); if (offset == search_length) { - printk(BIOS_DEBUG, - "Error: Could not locate '%s' in VPD\n", key); + printk(BIOS_ERR, "Could not locate '%s' in VPD\n", key); return 0; } printk(BIOS_DEBUG, "Located '%s' in VPD\n", key); diff --git a/src/mainboard/google/beltino/lan.c b/src/mainboard/google/beltino/lan.c index 1104ea7e13..baadf15d48 100644 --- a/src/mainboard/google/beltino/lan.c +++ b/src/mainboard/google/beltino/lan.c @@ -36,8 +36,7 @@ static unsigned char get_hex_digit(u8 *offset) retval = *offset - 'a' + 0x0a; } if (retval > 0x0F) { - printk(BIOS_DEBUG, "Error: Invalid Hex digit found: %c - 0x%02x\n", - *offset, *offset); + printk(BIOS_ERR, "Invalid Hex digit found: %c - 0x%02x\n", *offset, *offset); retval = 0; } @@ -53,8 +52,7 @@ static int get_mac_address(u32 *high_dword, u32 *low_dword, offset = search(key, search_address, sizeof(key) - 1, search_length); if (offset == search_length) { - printk(BIOS_DEBUG, - "Error: Could not locate '%s' in VPD\n", key); + printk(BIOS_ERR, "Could not locate '%s' in VPD\n", key); return 0; } printk(BIOS_DEBUG, "Located '%s' in VPD\n", key); diff --git a/src/mainboard/google/butterfly/mainboard.c b/src/mainboard/google/butterfly/mainboard.c index f428e69e0e..67f371c656 100644 --- a/src/mainboard/google/butterfly/mainboard.c +++ b/src/mainboard/google/butterfly/mainboard.c @@ -40,7 +40,7 @@ static unsigned char get_hex_digit(char *offset) retval = *offset - 'a' + 0x0a; } if (retval > 0x0F) { - printk(BIOS_DEBUG, "Error: Invalid Hex digit found: %c - 0x%02x\n", + printk(BIOS_ERR, "Invalid Hex digit found: %c - 0x%02x\n", *offset, (unsigned char)*offset); retval = 0; } @@ -58,8 +58,7 @@ static int get_mac_address(u32 *high_dword, u32 *low_dword, offset = search(key, (char *)search_address, sizeof(key) - 1, search_length); if (offset == search_length) { - printk(BIOS_DEBUG, - "Error: Could not locate '%s' in VPD\n", key); + printk(BIOS_ERR, "Could not locate '%s' in VPD\n", key); return 0; } printk(BIOS_DEBUG, "Located '%s' in VPD\n", key); @@ -149,7 +148,7 @@ static void program_keyboard_type(u32 search_address, u32 search_length) kbd_type = EC_KBD_JP; } } else { - printk(BIOS_DEBUG, "Error: Could not locate VPD area\n"); + printk(BIOS_ERR, "Could not locate VPD area\n"); } printk(BIOS_DEBUG, "Setting Keyboard type in EC to "); diff --git a/src/mainboard/google/jecht/lan.c b/src/mainboard/google/jecht/lan.c index a431393b00..1f90aa7ccf 100644 --- a/src/mainboard/google/jecht/lan.c +++ b/src/mainboard/google/jecht/lan.c @@ -36,8 +36,7 @@ static unsigned char get_hex_digit(u8 *offset) retval = *offset - 'a' + 0x0a; } if (retval > 0x0F) { - printk(BIOS_DEBUG, "Error: Invalid Hex digit found: %c - 0x%02x\n", - *offset, *offset); + printk(BIOS_ERR, "Invalid Hex digit found: %c - 0x%02x\n", *offset, *offset); retval = 0; } @@ -53,8 +52,7 @@ static int get_mac_address(u32 *high_dword, u32 *low_dword, offset = search(key, search_address, sizeof(key) - 1, search_length); if (offset == search_length) { - printk(BIOS_DEBUG, - "Error: Could not locate '%s' in VPD\n", key); + printk(BIOS_ERR, "Could not locate '%s' in VPD\n", key); return 0; } printk(BIOS_DEBUG, "Located '%s' in VPD\n", key); diff --git a/src/mainboard/google/rambi/variants/ninja/lan.c b/src/mainboard/google/rambi/variants/ninja/lan.c index 0abbffe5f8..8dfdb08226 100644 --- a/src/mainboard/google/rambi/variants/ninja/lan.c +++ b/src/mainboard/google/rambi/variants/ninja/lan.c @@ -35,8 +35,7 @@ static unsigned char get_hex_digit(u8 *offset) retval = *offset - 'a' + 0x0a; } if (retval > 0x0F) { - printk(BIOS_DEBUG, "Error: Invalid Hex digit found: %c - 0x%02x\n", - *offset, *offset); + printk(BIOS_ERR, "Invalid Hex digit found: %c - 0x%02x\n", *offset, *offset); retval = 0; } @@ -52,8 +51,7 @@ static int get_mac_address(u32 *high_dword, u32 *low_dword, offset = search(key, search_address, sizeof(key) - 1, search_length); if (offset == search_length) { - printk(BIOS_DEBUG, - "Error: Could not locate '%s' in VPD\n", key); + printk(BIOS_ERR, "Could not locate '%s' in VPD\n", key); return 0; } printk(BIOS_DEBUG, "Located '%s' in VPD\n", key); diff --git a/src/mainboard/google/rambi/variants/sumo/lan.c b/src/mainboard/google/rambi/variants/sumo/lan.c index 66083ae466..168f8b50dc 100644 --- a/src/mainboard/google/rambi/variants/sumo/lan.c +++ b/src/mainboard/google/rambi/variants/sumo/lan.c @@ -35,8 +35,7 @@ static unsigned char get_hex_digit(u8 *offset) retval = *offset - 'a' + 0x0a; } if (retval > 0x0F) { - printk(BIOS_DEBUG, "Error: Invalid Hex digit found: %c - 0x%02x\n", - *offset, *offset); + printk(BIOS_ERR, "Invalid Hex digit found: %c - 0x%02x\n", *offset, *offset); retval = 0; } @@ -52,8 +51,7 @@ static int get_mac_address(u32 *high_dword, u32 *low_dword, offset = search(key, search_address, sizeof(key) - 1, search_length); if (offset == search_length) { - printk(BIOS_DEBUG, - "Error: Could not locate '%s' in VPD\n", key); + printk(BIOS_ERR, "Could not locate '%s' in VPD\n", key); return 0; } printk(BIOS_DEBUG, "Located '%s' in VPD\n", key); -- cgit v1.2.3