From 0995b2da3856d3b363c8cb3b011418ae469cc1e4 Mon Sep 17 00:00:00 2001 From: Furquan Shaikh Date: Mon, 12 Mar 2018 06:29:52 -0700 Subject: mb/google/poppy/variants/nami: Use internal pulldown for MEM_CONFIG_4 Since nami proto did not have any external pull on MEM_CONFIG_4, use a weak internal pull down before reading it. BUG=b:74420123 TEST=Verified that the value read for MEM_CONFIG_4 is correct on nami. Change-Id: I45989d2ca35b863f391baba9e2f2e602033217d4 Signed-off-by: Furquan Shaikh Reviewed-on: https://review.coreboot.org/25103 Tested-by: build bot (Jenkins) Reviewed-by: Aaron Durbin --- src/mainboard/google/poppy/variants/nami/memory.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/mainboard') diff --git a/src/mainboard/google/poppy/variants/nami/memory.c b/src/mainboard/google/poppy/variants/nami/memory.c index 6aa0e7610f..082b9a4417 100644 --- a/src/mainboard/google/poppy/variants/nami/memory.c +++ b/src/mainboard/google/poppy/variants/nami/memory.c @@ -82,7 +82,7 @@ static void fill_ddr4_memory_params(struct memory_params *p) void variant_memory_params(struct memory_params *p) { memset(p, 0, sizeof(*p)); - gpio_input(GPIO_MEM_CONFIG_4); + gpio_input_pulldown(GPIO_MEM_CONFIG_4); if (gpio_get(GPIO_MEM_CONFIG_4)) /* set to LPDDR3 */ fill_lpddr3_memory_params(p); -- cgit v1.2.3