From 054516648542f8228d201ea56d8db157e4ec703f Mon Sep 17 00:00:00 2001 From: Pratik Prajapati Date: Wed, 27 Jun 2018 11:17:56 -0700 Subject: mb/google/poppy/variants/nocturne: enable p-states This patch enables p-states for nocturne which was disabled by commit de31587a (mb/google/poppy/variants/nocturne: disable p-states). p-states feature was disabled as a temporary work-around as system was getting hung while booting up. Now with IMVP7 firmwware turning and hardware rework the issue is not seen, so its safe to enable p-states. BUG=b:79666828 BRANCH=none TEST=cherry picked Change-Id: I4c67c6a095aecc158e529a6b393baf03ec358a3d patch and then "emerge-nocturne depthcharge coreboot chromeos-bootimage" , flash spi image onto nocturne, boot to kernel and verify device stays alive and responsive for several minutes without locking up. Change-Id: I82d1516998cc26b789faa5d4e897feb06dc06020 Signed-off-by: Pratik Prajapati Reviewed-on: https://review.coreboot.org/27257 Reviewed-by: Paul Menzel Reviewed-by: Nick Vaccaro Tested-by: build bot (Jenkins) --- src/mainboard/google/poppy/variants/nocturne/devicetree.cb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'src/mainboard') diff --git a/src/mainboard/google/poppy/variants/nocturne/devicetree.cb b/src/mainboard/google/poppy/variants/nocturne/devicetree.cb index 1d00bc2f17..32d4f55324 100644 --- a/src/mainboard/google/poppy/variants/nocturne/devicetree.cb +++ b/src/mainboard/google/poppy/variants/nocturne/devicetree.cb @@ -59,8 +59,8 @@ chip soc/intel/skylake register "PmTimerDisabled" = "1" register "VmxEnable" = "1" - # Disable P-States - register "speed_shift_enable" = "0" + # Set speed_shift_enable to 1 to enable P-States, and 0 to disable + register "speed_shift_enable" = "1" register "dptf_enable" = "1" register "tdp_pl2_override" = "15" register "psys_pmax" = "45" -- cgit v1.2.3