From 034920c1d438ff39f9243a1d6b0d41957405d34c Mon Sep 17 00:00:00 2001 From: Felix Singer Date: Fri, 16 Dec 2022 02:25:30 +0100 Subject: tree: Replace ShiftRight(a,b,c) with ASL 2.0 syntax Replace `ShiftRight (a, b, c)` with `c = a >> b`. One case was simplified to just `a >> b`. Change-Id: I889012b0a3067138e6f02d3fe8e97151effb5c2a Signed-off-by: Felix Singer Reviewed-on: https://review.coreboot.org/c/coreboot/+/70840 Reviewed-by: Caveh Jalali Tested-by: build bot (Jenkins) Reviewed-by: Eric Lai --- src/mainboard/aopen/dxplplusu/acpi/e7505_pri.asl | 2 +- src/mainboard/aopen/dxplplusu/acpi/e7505_sec.asl | 2 +- .../google/cyan/variants/terra/include/variant/acpi/mainboard.asl | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) (limited to 'src/mainboard') diff --git a/src/mainboard/aopen/dxplplusu/acpi/e7505_pri.asl b/src/mainboard/aopen/dxplplusu/acpi/e7505_pri.asl index 353f5e7485..5f27bff67c 100644 --- a/src/mainboard/aopen/dxplplusu/acpi/e7505_pri.asl +++ b/src/mainboard/aopen/dxplplusu/acpi/e7505_pri.asl @@ -48,7 +48,7 @@ Device (MBRS) CreateDWordField (MSBF, \_SB.MBRS._Y1D._MAX, MS01) CreateDWordField (MSBF, \_SB.MBRS._Y1D._LEN, MEM2) And (\_SB.PCI0.TOLM, 0xF800, Local1) - ShiftRight (Local1, 0x04, Local1) + Local1 >>= 4 Local1-- If (Local1 > 0x10) { diff --git a/src/mainboard/aopen/dxplplusu/acpi/e7505_sec.asl b/src/mainboard/aopen/dxplplusu/acpi/e7505_sec.asl index 400a5d7092..a2537c271b 100644 --- a/src/mainboard/aopen/dxplplusu/acpi/e7505_sec.asl +++ b/src/mainboard/aopen/dxplplusu/acpi/e7505_sec.asl @@ -42,7 +42,7 @@ Method (_CRS, 0, NotSerialized) CreateDWordField (PBRS, \_SB.PCI0._Y08._MAX, MEMH) CreateDWordField (PBRS, \_SB.PCI0._Y08._LEN, LENM) And (\_SB.PCI0.TOLM, 0xF800, Local1) - ShiftRight (Local1, 0x04, Local1) + Local1 >>= 4 ShiftLeft (Local1, 0x14, MEML) MEMH = IO_APIC_ADDR - 1 LENM = IO_APIC_ADDR - MEML diff --git a/src/mainboard/google/cyan/variants/terra/include/variant/acpi/mainboard.asl b/src/mainboard/google/cyan/variants/terra/include/variant/acpi/mainboard.asl index 0bee309e14..1f46c69aeb 100644 --- a/src/mainboard/google/cyan/variants/terra/include/variant/acpi/mainboard.asl +++ b/src/mainboard/google/cyan/variants/terra/include/variant/acpi/mainboard.asl @@ -10,7 +10,7 @@ Scope (\_SB) { Method (GPID, 0, Serialized) // GPID: Get Project ID for Terra2/Terra3 { - And( ShiftRight (\BDID, 3, Local0), 0x01, Local0) + And(\BDID >> 3, 0x01, Local0) Return (Local0) } } -- cgit v1.2.3