From 7b23ae0e8938eb71453cbc28c2cc74c14a4039ae Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ky=C3=B6sti=20M=C3=A4lkki?= Date: Fri, 4 Jul 2014 16:14:37 +0300 Subject: AGESA: Trace execution with AGESAWRAPPER() MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Implement logging just once to have uniform output. Change-Id: I8db694a3bf6b1af459bdf98f7acb99edf4dd07f7 Signed-off-by: Kyösti Mälkki Reviewed-on: http://review.coreboot.org/6180 Tested-by: build bot (Jenkins) Reviewed-by: Edward O'Callaghan --- src/mainboard/tyan/s8226/romstage.c | 29 +++++------------------------ 1 file changed, 5 insertions(+), 24 deletions(-) (limited to 'src/mainboard/tyan') diff --git a/src/mainboard/tyan/s8226/romstage.c b/src/mainboard/tyan/s8226/romstage.c index 8b8fa5fe0e..9624af8658 100644 --- a/src/mainboard/tyan/s8226/romstage.c +++ b/src/mainboard/tyan/s8226/romstage.c @@ -28,6 +28,7 @@ #include "cpu/x86/lapic.h" #include "cpu/amd/car.h" #include "agesawrapper.h" +#include #include "northbridge/amd/agesa/family10/reset_test.h" #include #include @@ -64,12 +65,7 @@ void cache_as_ram_main(unsigned long bist, unsigned long cpu_init_detectedx) printk(BIOS_DEBUG, "cpu_init_detectedx = %08lx \n", cpu_init_detectedx); post_code(0x37); - val = agesawrapper_amdinitreset(); - if (val) { - printk(BIOS_DEBUG, "agesawrapper_amdinitreset failed: %x \n", val); - } else { - printk(BIOS_DEBUG, "agesawrapper_amdinitreset passed\n"); - } + AGESAWRAPPER(amdinitreset); if (!cpu_init_detectedx && boot_cpu()) { post_code(0x38); @@ -84,12 +80,7 @@ void cache_as_ram_main(unsigned long bist, unsigned long cpu_init_detectedx) sb_Poweron_Init(); } post_code(0x3B); - val = agesawrapper_amdinitearly(); - if(val) { - printk(BIOS_DEBUG, "agesawrapper_amdinitearly failed: %x \n", val); - } else { - printk(BIOS_DEBUG, "agesawrapper_amdinitearly passed\n"); - } + AGESAWRAPPER(amdinitearly); post_code(0x3C); /* W83627DHG pin89,90 function select is RSTOUT3#, RSTOUT2# by default. @@ -109,20 +100,10 @@ void cache_as_ram_main(unsigned long bist, unsigned long cpu_init_detectedx) } post_code(0x40); - val = agesawrapper_amdinitpost(); - if (val) { - printk(BIOS_DEBUG, "agesawrapper_amdinitpost failed: %x \n", val); - } else { - printk(BIOS_DEBUG, "agesawrapper_amdinitpost passed\n"); - } + AGESAWRAPPER(amdinitpost); post_code(0x41); - val = agesawrapper_amdinitenv(); - if(val) { - printk(BIOS_DEBUG, "agesawrapper_amdinitenv failed: %x \n", val); - } - printk(BIOS_DEBUG, "agesawrapper_amdinitenv passed\n"); - + AGESAWRAPPER(amdinitenv); post_code(0x42); post_code(0x50); -- cgit v1.2.3