From 705ebbea04778cef3b51bc7a06b216fd73a193d2 Mon Sep 17 00:00:00 2001 From: Tim Crawford Date: Fri, 19 Aug 2022 13:18:24 -0600 Subject: mb/system76: Reset Realtek codec before configuring Perform a codec reset before configuring to avoid potential issues like oryp5 had before 86f410479ca9 ("mb/system76/oryp5: Reset HDA before configuring"). Inspecting proprietary firmware for multiple boards shows that this is always done as well. Change-Id: I64c1fd23f708f77a81fad0bc889f42d4df3f6e61 Signed-off-by: Tim Crawford Reviewed-on: https://review.coreboot.org/c/coreboot/+/66918 Reviewed-by: Paul Menzel Tested-by: build bot (Jenkins) Reviewed-by: Jeremy Soller --- src/mainboard/system76/tgl-u/variants/darp7/hda_verb.c | 3 ++- src/mainboard/system76/tgl-u/variants/galp5/hda_verb.c | 3 ++- src/mainboard/system76/tgl-u/variants/lemp10/hda_verb.c | 3 ++- 3 files changed, 6 insertions(+), 3 deletions(-) (limited to 'src/mainboard/system76/tgl-u') diff --git a/src/mainboard/system76/tgl-u/variants/darp7/hda_verb.c b/src/mainboard/system76/tgl-u/variants/darp7/hda_verb.c index dc5f72e5d8..53a47bdb47 100644 --- a/src/mainboard/system76/tgl-u/variants/darp7/hda_verb.c +++ b/src/mainboard/system76/tgl-u/variants/darp7/hda_verb.c @@ -6,8 +6,9 @@ const u32 cim_verb_data[] = { /* Realtek, ALC293 */ 0x10ec0293, /* Vendor ID */ 0x155851a1, /* Subsystem ID */ - 12, /* Number of entries */ + 13, /* Number of entries */ AZALIA_SUBVENDOR(0, 0x155851a1), + AZALIA_RESET(1), AZALIA_PIN_CFG(0, 0x12, 0x90a60130), AZALIA_PIN_CFG(0, 0x13, 0x40000000), AZALIA_PIN_CFG(0, 0x14, 0x90170110), diff --git a/src/mainboard/system76/tgl-u/variants/galp5/hda_verb.c b/src/mainboard/system76/tgl-u/variants/galp5/hda_verb.c index 1f21ff77e7..c0afb196dc 100644 --- a/src/mainboard/system76/tgl-u/variants/galp5/hda_verb.c +++ b/src/mainboard/system76/tgl-u/variants/galp5/hda_verb.c @@ -6,8 +6,9 @@ const u32 cim_verb_data[] = { /* Realtek, ALC293 */ 0x10ec0293, /* Vendor ID */ 0x15584018, /* Subsystem ID */ - 12, /* Number of entries */ + 13, /* Number of entries */ AZALIA_SUBVENDOR(0, 0x15584018), + AZALIA_RESET(1), AZALIA_PIN_CFG(0, 0x12, 0x90a60130), AZALIA_PIN_CFG(0, 0x13, 0x40000000), AZALIA_PIN_CFG(0, 0x14, 0x90170110), diff --git a/src/mainboard/system76/tgl-u/variants/lemp10/hda_verb.c b/src/mainboard/system76/tgl-u/variants/lemp10/hda_verb.c index 1259ba10ff..43a0ee5aed 100644 --- a/src/mainboard/system76/tgl-u/variants/lemp10/hda_verb.c +++ b/src/mainboard/system76/tgl-u/variants/lemp10/hda_verb.c @@ -6,8 +6,9 @@ const u32 cim_verb_data[] = { /* Realtek, ALC293 */ 0x10ec0293, /* Vendor ID */ 0x155814a1, /* Subsystem ID */ - 12, /* Number of entries */ + 13, /* Number of entries */ AZALIA_SUBVENDOR(0, 0x155814a1), + AZALIA_RESET(1), AZALIA_PIN_CFG(0, 0x12, 0x90a60130), AZALIA_PIN_CFG(0, 0x13, 0x40000000), AZALIA_PIN_CFG(0, 0x14, 0x90170110), -- cgit v1.2.3