From d482c7dace772278d988682e94247e3801587ff7 Mon Sep 17 00:00:00 2001 From: Kyösti Mälkki Date: Thu, 3 Jan 2019 11:38:35 +0200 Subject: amdfam10 boards: Drop global bus_isa variable MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Value of the global is never evaluated. Change-Id: I74106b0f5f033053288882a5bcd3c1dba3235ac0 Signed-off-by: Kyösti Mälkki Reviewed-on: https://review.coreboot.org/c/30628 Tested-by: build bot (Jenkins) Reviewed-by: Arthur Heymans Reviewed-by: Angel Pons --- src/mainboard/supermicro/h8scm_fam10/get_bus_conf.c | 6 ------ src/mainboard/supermicro/h8scm_fam10/irq_tables.c | 1 - 2 files changed, 7 deletions(-) (limited to 'src/mainboard/supermicro/h8scm_fam10') diff --git a/src/mainboard/supermicro/h8scm_fam10/get_bus_conf.c b/src/mainboard/supermicro/h8scm_fam10/get_bus_conf.c index 255fd898f9..b242a81a1f 100644 --- a/src/mainboard/supermicro/h8scm_fam10/get_bus_conf.c +++ b/src/mainboard/supermicro/h8scm_fam10/get_bus_conf.c @@ -24,7 +24,6 @@ /* Global variables for MB layouts and these will be shared by irqtable mptable * and acpi_tables busnum is default. */ -u8 bus_isa; u8 bus_sr5650[14]; u8 bus_sp5100[2]; u32 apicid_sp5100; @@ -90,8 +89,6 @@ void get_bus_conf(void) dev = dev_find_slot(bus_sp5100[0], PCI_DEVFN(sbdn_sp5100 + 0x14, 4)); if (dev) { bus_sp5100[1] = pci_read_config8(dev, PCI_SECONDARY_BUS); - bus_isa = pci_read_config8(dev, PCI_SUBORDINATE_BUS); - bus_isa++; } /* sr5650 */ @@ -100,14 +97,11 @@ void get_bus_conf(void) if (dev) { bus_sr5650[i] = pci_read_config8(dev, PCI_SECONDARY_BUS); if(255 != bus_sr5650[i]) { - bus_isa = pci_read_config8(dev, PCI_SUBORDINATE_BUS); - bus_isa++; } } } /* I/O APICs: APIC ID Version State Address */ - bus_isa = 10; if (IS_ENABLED(CONFIG_LOGICAL_CPUS)) apicid_base = get_apicid_base(1); else diff --git a/src/mainboard/supermicro/h8scm_fam10/irq_tables.c b/src/mainboard/supermicro/h8scm_fam10/irq_tables.c index 73f440ffd6..aa78b45d67 100644 --- a/src/mainboard/supermicro/h8scm_fam10/irq_tables.c +++ b/src/mainboard/supermicro/h8scm_fam10/irq_tables.c @@ -40,7 +40,6 @@ static void write_pirq_info(struct irq_info *pirq_info, u8 bus, u8 devfn, pirq_info->rfu = rfu; } -extern u8 bus_isa; extern u8 bus_rs780[8]; extern u8 bus_sp5100[2]; extern unsigned long sbdn_sp5100; -- cgit v1.2.3