From 392de45ae2d9550c3b95078bff7a52c9e5eed563 Mon Sep 17 00:00:00 2001 From: Edward O'Callaghan Date: Thu, 17 Apr 2014 22:24:40 +1000 Subject: mainboard/*: Remove DUMP_ACPI_TABLES from amd boards Dumping the ACPI tables in this way has limited use, is not likely to be used and is poorly implemented. There are much more sophisticated tools available on Linux for debugging ACPI as such this code is outside the scope of coreboots 'bring up the hardware only' philosophy. A more generic implemention could be done with hexdump() in coreboot proper following on from this cleanup. Change-Id: Ifd3bfb76338609d18fcf7158d3c9a6d7c06c8847 Signed-off-by: Edward O'Callaghan Reviewed-on: http://review.coreboot.org/5530 Tested-by: build bot (Jenkins) Reviewed-by: Paul Menzel Reviewed-by: Alexandru Gagniuc --- src/mainboard/supermicro/h8qgi/acpi_tables.c | 45 ---------------------------- 1 file changed, 45 deletions(-) (limited to 'src/mainboard/supermicro/h8qgi') diff --git a/src/mainboard/supermicro/h8qgi/acpi_tables.c b/src/mainboard/supermicro/h8qgi/acpi_tables.c index 90d39bc19e..8091d1d4f1 100644 --- a/src/mainboard/supermicro/h8qgi/acpi_tables.c +++ b/src/mainboard/supermicro/h8qgi/acpi_tables.c @@ -30,27 +30,8 @@ #include #include "agesawrapper.h" -#define DUMP_ACPI_TABLES 0 - -#if DUMP_ACPI_TABLES == 1 -static void dump_mem(u32 start, u32 end) -{ - - u32 i; - print_debug("dump_mem:"); - for (i = start; i < end; i++) { - if ((i & 0xf) == 0) { - printk(BIOS_DEBUG, "\n%08x:", i); - } - printk(BIOS_DEBUG, " %02x", (u8)*((u8 *)i)); - } - print_debug("\n"); -} -#endif - extern const unsigned char AmlCode[]; - unsigned long acpi_fill_mcfg(unsigned long current) { /* Just a dummy */ @@ -317,32 +298,6 @@ unsigned long write_acpi_tables(unsigned long start) current += ssdt2->length; acpi_add_table(rsdp,ssdt2); -#if DUMP_ACPI_TABLES == 1 - printk(BIOS_DEBUG, "rsdp\n"); - dump_mem(rsdp, ((void *)rsdp) + sizeof(acpi_rsdp_t)); - - printk(BIOS_DEBUG, "rsdt\n"); - dump_mem(rsdt, ((void *)rsdt) + sizeof(acpi_rsdt_t)); - - printk(BIOS_DEBUG, "madt\n"); - dump_mem(madt, ((void *)madt) + madt->header.length); - - printk(BIOS_DEBUG, "srat\n"); - dump_mem(srat, ((void *)srat) + srat->header.length); - - printk(BIOS_DEBUG, "slit\n"); - dump_mem(slit, ((void *)slit) + slit->header.length); - - printk(BIOS_DEBUG, "ssdt\n"); - dump_mem(ssdt, ((void *)ssdt) + ssdt->length); - - printk(BIOS_DEBUG, "fadt\n"); - dump_mem(fadt, ((void *)fadt) + fadt->header.length); - - printk(BIOS_DEBUG, "hest\n"); - dump_mem(hest, ((void *)hest) + hest->header.length); -#endif - printk(BIOS_INFO, "ACPI: done.\n"); return current; } -- cgit v1.2.3