From 7b49c3711298c06f4293c6b31a16834e3e042423 Mon Sep 17 00:00:00 2001 From: Angel Pons Date: Sun, 13 Nov 2022 12:48:44 +0100 Subject: mainboard: Drop invalid `hyper_threading` option MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Drop the `hyper_threading` CMOS option from most boards, as it's most likely not working properly and causing problems. The main reasons to remove the option are: * The used enum is backwards (0 ---> Enable, 1 ---> Disable) * Platform/SoC code does not honor the `hyper_threading` option Also, remove the now-unused enum used by the `hyper_threading` option. Change-Id: Ia8980a951f4751bc2e1a5d0e88835f578259b256 Signed-off-by: Angel Pons Reviewed-on: https://review.coreboot.org/c/coreboot/+/69523 Reviewed-by: Michael Niewöhner Tested-by: build bot (Jenkins) Reviewed-by: Sean Rhodes --- src/mainboard/sapphire/pureplatinumh61/cmos.default | 1 - src/mainboard/sapphire/pureplatinumh61/cmos.layout | 5 ----- 2 files changed, 6 deletions(-) (limited to 'src/mainboard/sapphire') diff --git a/src/mainboard/sapphire/pureplatinumh61/cmos.default b/src/mainboard/sapphire/pureplatinumh61/cmos.default index 7cd30cc5f9..38f2bd3d69 100644 --- a/src/mainboard/sapphire/pureplatinumh61/cmos.default +++ b/src/mainboard/sapphire/pureplatinumh61/cmos.default @@ -3,4 +3,3 @@ debug_level=Debug power_on_after_fail=Enable nmi=Enable sata_mode=AHCI -hyper_threading=Enable diff --git a/src/mainboard/sapphire/pureplatinumh61/cmos.layout b/src/mainboard/sapphire/pureplatinumh61/cmos.layout index 979c8e28ad..fabafefa44 100644 --- a/src/mainboard/sapphire/pureplatinumh61/cmos.layout +++ b/src/mainboard/sapphire/pureplatinumh61/cmos.layout @@ -21,9 +21,6 @@ entries 421 1 e 9 sata_mode -# coreboot config options: cpu -424 1 e 2 hyper_threading - # coreboot config options: northbridge 432 3 e 11 gfx_uma_size @@ -42,8 +39,6 @@ enumerations #ID value text 1 0 Disable 1 1 Enable -2 0 Enable -2 1 Disable 4 0 Fallback 4 1 Normal 6 0 Emergency -- cgit v1.2.3