From 25852099eeacc66fa4e012f128b75202517eaabe Mon Sep 17 00:00:00 2001 From: Patrick Rudolph Date: Thu, 7 Apr 2016 18:51:12 +0200 Subject: mb/samsung/lumpy/romstage: read SPD data of removable DIMM The removable DIMM SPD data wasn't read. As a result the system only uses the 2GB onboard memory and the GNU Linux kernel paniced in acpi_ds_build_internal_package_obj. Read the SPD and allow native raminit and MRC blob to use the removable DIMM. The system is able to use the removable dimm and the kernel panic is gone. Change-Id: I30eed747f924cb0029de55d2ab85c5a94075dc1b Signed-off-by: Patrick Rudolph Tested-by: Idwer Vollering Reviewed-on: https://review.coreboot.org/14278 Tested-by: build bot (Jenkins) Reviewed-by: Martin Roth --- src/mainboard/samsung/lumpy/romstage.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) (limited to 'src/mainboard/samsung') diff --git a/src/mainboard/samsung/lumpy/romstage.c b/src/mainboard/samsung/lumpy/romstage.c index 650c8d771e..4d318b7069 100644 --- a/src/mainboard/samsung/lumpy/romstage.c +++ b/src/mainboard/samsung/lumpy/romstage.c @@ -216,6 +216,8 @@ void mainboard_fill_pei_data(struct pei_data *pei_data) *pei_data = pei_data_template; // leave onboard dimm address at f0, and copy spd data there. memcpy(pei_data->spd_data[0], locate_spd(), 256); + /* read removable dimm spd */ + read_spd(&pei_data->spd_data[2], 0x50); } const struct southbridge_usb_port mainboard_usb_ports[] = { @@ -238,7 +240,10 @@ const struct southbridge_usb_port mainboard_usb_ports[] = { void mainboard_get_spd(spd_raw_data *spd) { - memcpy(&spd[0], locate_spd(), 128); + /* get onboard dimm spd */ + memcpy(&spd[0], locate_spd(), 256); + /* read removable dimm spd */ + read_spd(&spd[2], 0x50); } void mainboard_early_init(int s3resume) -- cgit v1.2.3