From 2c0aa00d6e562b2e6dbe580e188e24ce5e4336e2 Mon Sep 17 00:00:00 2001 From: Angel Pons Date: Tue, 3 Nov 2020 00:03:32 +0100 Subject: mb/**/cmos.layout: Remove crusty comments Most of these comments have been copy-pasted or serve no purpose other than to eventually turn into misleading info. While the description of the first 120 bits of CMOS could be useful, it should instead be added to the documentation for the CMOS option infrastructure, or /dev/null. Moreover, trim down newlines to no more than two consecutive newlines. Change-Id: I119b248821221e68c4e31edba71ba83b7d2e14e9 Signed-off-by: Angel Pons Reviewed-on: https://review.coreboot.org/c/coreboot/+/47143 Tested-by: build bot (Jenkins) Reviewed-by: Frans Hendriks --- src/mainboard/roda/rk886ex/cmos.layout | 27 --------------------------- src/mainboard/roda/rk9/cmos.layout | 28 ---------------------------- src/mainboard/roda/rv11/cmos.layout | 30 ------------------------------ 3 files changed, 85 deletions(-) (limited to 'src/mainboard/roda') diff --git a/src/mainboard/roda/rk886ex/cmos.layout b/src/mainboard/roda/rk886ex/cmos.layout index 755aad009f..f96a51aae0 100644 --- a/src/mainboard/roda/rk886ex/cmos.layout +++ b/src/mainboard/roda/rk886ex/cmos.layout @@ -3,43 +3,19 @@ # ----------------------------------------------------------------- entries -# ----------------------------------------------------------------- -# Status Register A -# ----------------------------------------------------------------- -# Status Register B -# ----------------------------------------------------------------- -# Status Register C -#96 4 r 0 status_c_rsvd -#100 1 r 0 uf_flag -#101 1 r 0 af_flag -#102 1 r 0 pf_flag -#103 1 r 0 irqf_flag -# ----------------------------------------------------------------- -# Status Register D -#104 7 r 0 status_d_rsvd -#111 1 r 0 valid_cmos_ram -# ----------------------------------------------------------------- -# Diagnostic Status Register -#112 8 r 0 diag_rsvd1 - # ----------------------------------------------------------------- 0 120 r 0 reserved_memory -#120 264 r 0 unused # ----------------------------------------------------------------- # RTC_BOOT_BYTE (coreboot hardcoded) 384 1 e 4 boot_option 388 4 h 0 reboot_counter -#390 2 r 0 unused? # ----------------------------------------------------------------- # coreboot config options: console -#392 3 r 0 unused 395 4 e 6 debug_level -#399 1 r 0 unused # coreboot config options: cpu -#401 7 r 0 unused # coreboot config options: southbridge 408 1 e 1 nmi @@ -48,17 +24,14 @@ entries # coreboot config options: northbridge 411 3 e 11 gfx_uma_size - # coreboot config options: bootloader 416 512 s 0 boot_devices 928 8 h 0 boot_default 936 1 e 8 cmos_defaults_loaded 937 1 e 1 lpt -#938 46 r 0 unused # coreboot config options: check sums 984 16 h 0 check_sum -#1000 24 r 0 amd_reserved # RAM initialization internal data 1024 8 r 0 C0WL0REOST diff --git a/src/mainboard/roda/rk9/cmos.layout b/src/mainboard/roda/rk9/cmos.layout index 2dce4640c9..526bc5e690 100644 --- a/src/mainboard/roda/rk9/cmos.layout +++ b/src/mainboard/roda/rk9/cmos.layout @@ -3,53 +3,27 @@ # ----------------------------------------------------------------- entries -# ----------------------------------------------------------------- -# Status Register A -# ----------------------------------------------------------------- -# Status Register B -# ----------------------------------------------------------------- -# Status Register C -#96 4 r 0 status_c_rsvd -#100 1 r 0 uf_flag -#101 1 r 0 af_flag -#102 1 r 0 pf_flag -#103 1 r 0 irqf_flag -# ----------------------------------------------------------------- -# Status Register D -#104 7 r 0 status_d_rsvd -#111 1 r 0 valid_cmos_ram -# ----------------------------------------------------------------- -# Diagnostic Status Register -#112 8 r 0 diag_rsvd1 - # ----------------------------------------------------------------- 0 120 r 0 reserved_memory -#120 264 r 0 unused # ----------------------------------------------------------------- # RTC_BOOT_BYTE (coreboot hardcoded) 384 1 e 4 boot_option 388 4 h 0 reboot_counter -#390 2 r 0 unused? # ----------------------------------------------------------------- # coreboot config options: console -#392 3 r 0 unused 395 4 e 6 debug_level -#399 1 r 0 unused # coreboot config options: cpu -#400 8 r 0 unused # coreboot config options: southbridge 408 1 e 9 sata_mode -#409 7 r 0 unused # coreboot config options: bootloader 416 512 s 0 boot_devices 928 8 h 0 boot_default 936 1 e 8 cmos_defaults_loaded -#937 7 r 0 unused # coreboot config options: check sums 984 16 h 0 check_sum @@ -57,8 +31,6 @@ entries # coreboot config options: northbridge 1000 4 e 10 gfx_uma_size -#1004 20 r 0 unused - # RAM initialization internal data 1024 128 r 0 read_training_results diff --git a/src/mainboard/roda/rv11/cmos.layout b/src/mainboard/roda/rv11/cmos.layout index ea36a26644..c32eed267f 100644 --- a/src/mainboard/roda/rv11/cmos.layout +++ b/src/mainboard/roda/rv11/cmos.layout @@ -3,28 +3,8 @@ # ----------------------------------------------------------------- entries -# ----------------------------------------------------------------- -# Status Register A -# ----------------------------------------------------------------- -# Status Register B -# ----------------------------------------------------------------- -# Status Register C -#96 4 r 0 status_c_rsvd -#100 1 r 0 uf_flag -#101 1 r 0 af_flag -#102 1 r 0 pf_flag -#103 1 r 0 irqf_flag -# ----------------------------------------------------------------- -# Status Register D -#104 7 r 0 status_d_rsvd -#111 1 r 0 valid_cmos_ram -# ----------------------------------------------------------------- -# Diagnostic Status Register -#112 8 r 0 diag_rsvd1 - # ----------------------------------------------------------------- 0 120 r 0 reserved_memory -#120 264 r 0 unused # ----------------------------------------------------------------- # RTC_BOOT_BYTE (coreboot hardcoded) @@ -34,40 +14,30 @@ entries # ----------------------------------------------------------------- # coreboot config options: console -#392 3 r 0 unused 395 4 e 5 debug_level -#399 1 r 0 unused # coreboot config options: cpu 400 1 e 2 hyper_threading 401 3 e 9 gfx_uma_size -#404 4 r 0 unused - # coreboot config options: southbridge 408 1 e 1 nmi -#409 2 r 0 unused 411 1 e 8 sata_mode -#412 4 r 0 unused # coreboot config options: bootloader 416 424 s 0 boot_devices 840 8 h 0 boot_default 848 1 e 7 cmos_defaults_loaded -#851 5 r 0 unused # coreboot config options: mainboard specific options -#856 40 r 0 unused # SandyBridge MRC Scrambler Seed values 896 32 r 0 mrc_scrambler_seed 928 32 r 0 mrc_scrambler_seed_s3 960 16 r 0 mrc_scrambler_seed_chk -#976 8 r 0 unused # coreboot config options: check sums 984 16 h 0 check_sum -#1000 24 r 0 amd_reserved # ----------------------------------------------------------------- -- cgit v1.2.3